Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 2141403002: Use unique pipe names for IPCChannelPosixTest tests (Closed)

Created:
4 years, 5 months ago by Ken Rockot(use gerrit already)
Modified:
4 years, 5 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use unique pipe names for IPCChannelPosixTest tests Eliminates races between IPCChannelPosixTest instances which were all using the same named pipe path to establish an IPC channel. BUG=627730 R=amistry@chromium.org Committed: https://crrev.com/4843d09c917b0b87c9ce31ec7315ff4d2f02da75 Cr-Commit-Position: refs/heads/master@{#405210}

Patch Set 1 #

Patch Set 2 : shorten pipe name to avoid mac max path issues #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -5 lines) Patch
M ipc/ipc_channel_posix_unittest.cc View 1 7 chunks +35 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Ken Rockot(use gerrit already)
This was a fun encounter. I wasted a lot of time thinking a test I ...
4 years, 5 months ago (2016-07-13 08:12:03 UTC) #1
Anand Mistry (off Chromium)
lgtm. yikes!
4 years, 5 months ago (2016-07-13 09:26:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2141403002/20001
4 years, 5 months ago (2016-07-13 17:30:01 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-13 17:36:10 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 17:39:35 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4843d09c917b0b87c9ce31ec7315ff4d2f02da75
Cr-Commit-Position: refs/heads/master@{#405210}

Powered by Google App Engine
This is Rietveld 408576698