Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(808)

Unified Diff: third_party/WebKit/Source/modules/fetch/Request.h

Issue 2141383002: [Fetch API] Remove HandleScope to protect local handles (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/fetch/Request.h
diff --git a/third_party/WebKit/Source/modules/fetch/Request.h b/third_party/WebKit/Source/modules/fetch/Request.h
index 57a9f3ba6273274223c3899585deb44d4d083ecb..569b84fabb9318265a9daea5a9aefe9fd2fbc16d 100644
--- a/third_party/WebKit/Source/modules/fetch/Request.h
+++ b/third_party/WebKit/Source/modules/fetch/Request.h
@@ -31,6 +31,8 @@ class MODULES_EXPORT Request final : public Body {
DEFINE_WRAPPERTYPEINFO();
WTF_MAKE_NONCOPYABLE(Request);
public:
+ // These "create" function must be called with entering an appropriate
+ // V8 context.
// From Request.idl:
static Request* create(ScriptState*, const RequestInfo&, const Dictionary&, ExceptionState&);
@@ -54,6 +56,7 @@ public:
String integrity() const;
// From Request.idl:
+ // This function must be called with entering an appropriate V8 context.
Request* clone(ScriptState*, ExceptionState&);
FetchRequestData* passRequestData(ScriptState*);
« no previous file with comments | « third_party/WebKit/Source/modules/fetch/FetchManager.cpp ('k') | third_party/WebKit/Source/modules/fetch/Request.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698