Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(967)

Unified Diff: third_party/WebKit/Source/modules/fetch/ResponseTest.cpp

Issue 2141383002: [Fetch API] Remove HandleScope to protect local handles (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/fetch/ResponseTest.cpp
diff --git a/third_party/WebKit/Source/modules/fetch/ResponseTest.cpp b/third_party/WebKit/Source/modules/fetch/ResponseTest.cpp
index 0fee482579424c4d7b75d70f15981c7a6ab49e5c..a4788b5d71eec4976745e93bdcb89e6bb5494727 100644
--- a/third_party/WebKit/Source/modules/fetch/ResponseTest.cpp
+++ b/third_party/WebKit/Source/modules/fetch/ResponseTest.cpp
@@ -70,6 +70,7 @@ TEST_F(ServiceWorkerResponseTest, FromFetchResponseData)
TEST_F(ServiceWorkerResponseTest, FromWebServiceWorkerResponse)
{
+ ScriptState::Scope scope(getScriptState());
std::unique_ptr<WebServiceWorkerResponse> webResponse = createTestWebServiceWorkerResponse();
Response* response = Response::create(getScriptState(), *webResponse);
ASSERT(response);
@@ -91,6 +92,7 @@ TEST_F(ServiceWorkerResponseTest, FromWebServiceWorkerResponse)
TEST_F(ServiceWorkerResponseTest, FromWebServiceWorkerResponseDefault)
{
+ ScriptState::Scope scope(getScriptState());
std::unique_ptr<WebServiceWorkerResponse> webResponse = createTestWebServiceWorkerResponse();
webResponse->setResponseType(WebServiceWorkerResponseTypeDefault);
Response* response = Response::create(getScriptState(), *webResponse);
@@ -105,6 +107,7 @@ TEST_F(ServiceWorkerResponseTest, FromWebServiceWorkerResponseDefault)
TEST_F(ServiceWorkerResponseTest, FromWebServiceWorkerResponseBasic)
{
+ ScriptState::Scope scope(getScriptState());
std::unique_ptr<WebServiceWorkerResponse> webResponse = createTestWebServiceWorkerResponse();
webResponse->setResponseType(WebServiceWorkerResponseTypeBasic);
Response* response = Response::create(getScriptState(), *webResponse);
@@ -119,6 +122,7 @@ TEST_F(ServiceWorkerResponseTest, FromWebServiceWorkerResponseBasic)
TEST_F(ServiceWorkerResponseTest, FromWebServiceWorkerResponseCORS)
{
+ ScriptState::Scope scope(getScriptState());
std::unique_ptr<WebServiceWorkerResponse> webResponse = createTestWebServiceWorkerResponse();
webResponse->setResponseType(WebServiceWorkerResponseTypeCORS);
Response* response = Response::create(getScriptState(), *webResponse);
@@ -133,6 +137,7 @@ TEST_F(ServiceWorkerResponseTest, FromWebServiceWorkerResponseCORS)
TEST_F(ServiceWorkerResponseTest, FromWebServiceWorkerResponseOpaque)
{
+ ScriptState::Scope scope(getScriptState());
std::unique_ptr<WebServiceWorkerResponse> webResponse = createTestWebServiceWorkerResponse();
webResponse->setResponseType(WebServiceWorkerResponseTypeOpaque);
Response* response = Response::create(getScriptState(), *webResponse);
@@ -198,6 +203,7 @@ BodyStreamBuffer* createHelloWorldBuffer(ScriptState* scriptState)
TEST_F(ServiceWorkerResponseTest, BodyStreamBufferCloneDefault)
{
+ ScriptState::Scope scope(getScriptState());
BodyStreamBuffer* buffer = createHelloWorldBuffer(getScriptState());
FetchResponseData* fetchResponseData = FetchResponseData::createWithBuffer(buffer);
fetchResponseData->setURL(KURL(ParsedURLString, "http://www.response.com"));
@@ -208,6 +214,7 @@ TEST_F(ServiceWorkerResponseTest, BodyStreamBufferCloneDefault)
TEST_F(ServiceWorkerResponseTest, BodyStreamBufferCloneBasic)
{
+ ScriptState::Scope scope(getScriptState());
BodyStreamBuffer* buffer = createHelloWorldBuffer(getScriptState());
FetchResponseData* fetchResponseData = FetchResponseData::createWithBuffer(buffer);
fetchResponseData->setURL(KURL(ParsedURLString, "http://www.response.com"));
@@ -219,6 +226,7 @@ TEST_F(ServiceWorkerResponseTest, BodyStreamBufferCloneBasic)
TEST_F(ServiceWorkerResponseTest, BodyStreamBufferCloneCORS)
{
+ ScriptState::Scope scope(getScriptState());
BodyStreamBuffer* buffer = createHelloWorldBuffer(getScriptState());
FetchResponseData* fetchResponseData = FetchResponseData::createWithBuffer(buffer);
fetchResponseData->setURL(KURL(ParsedURLString, "http://www.response.com"));
@@ -230,6 +238,7 @@ TEST_F(ServiceWorkerResponseTest, BodyStreamBufferCloneCORS)
TEST_F(ServiceWorkerResponseTest, BodyStreamBufferCloneOpaque)
{
+ ScriptState::Scope scope(getScriptState());
BodyStreamBuffer* buffer = createHelloWorldBuffer(getScriptState());
FetchResponseData* fetchResponseData = FetchResponseData::createWithBuffer(buffer);
fetchResponseData->setURL(KURL(ParsedURLString, "http://www.response.com"));
@@ -241,6 +250,7 @@ TEST_F(ServiceWorkerResponseTest, BodyStreamBufferCloneOpaque)
TEST_F(ServiceWorkerResponseTest, BodyStreamBufferCloneError)
{
+ ScriptState::Scope scope(getScriptState());
BodyStreamBuffer* buffer = new BodyStreamBuffer(getScriptState(), createFetchDataConsumerHandleFromWebHandle(createUnexpectedErrorDataConsumerHandle()));
FetchResponseData* fetchResponseData = FetchResponseData::createWithBuffer(buffer);
fetchResponseData->setURL(KURL(ParsedURLString, "http://www.response.com"));

Powered by Google App Engine
This is Rietveld 408576698