Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Unified Diff: third_party/WebKit/Source/modules/fetch/BodyStreamBufferTest.cpp

Issue 2141383002: [Fetch API] Remove HandleScope to protect local handles (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/fetch/BodyStreamBufferTest.cpp
diff --git a/third_party/WebKit/Source/modules/fetch/BodyStreamBufferTest.cpp b/third_party/WebKit/Source/modules/fetch/BodyStreamBufferTest.cpp
index defd82911b3fe6b64db20566556e4df06363a7d3..e6c77319e10b41e87762b6a336f57ca747705fd5 100644
--- a/third_party/WebKit/Source/modules/fetch/BodyStreamBufferTest.cpp
+++ b/third_party/WebKit/Source/modules/fetch/BodyStreamBufferTest.cpp
@@ -82,6 +82,7 @@ protected:
TEST_F(BodyStreamBufferTest, Tee)
{
+ ScriptState::Scope scope(getScriptState());
Checkpoint checkpoint;
MockFetchDataLoaderClient* client1 = MockFetchDataLoaderClient::create();
MockFetchDataLoaderClient* client2 = MockFetchDataLoaderClient::create();
@@ -174,6 +175,7 @@ TEST_F(BodyStreamBufferTest, TeeFromHandleMadeFromStream)
TEST_F(BodyStreamBufferTest, DrainAsBlobDataHandle)
{
+ ScriptState::Scope scope(getScriptState());
std::unique_ptr<BlobData> data = BlobData::create();
data->appendText("hello", false);
auto size = data->length();
@@ -193,6 +195,7 @@ TEST_F(BodyStreamBufferTest, DrainAsBlobDataHandle)
TEST_F(BodyStreamBufferTest, DrainAsBlobDataHandleReturnsNull)
{
+ ScriptState::Scope scope(getScriptState());
// This handle is not drainable.
std::unique_ptr<FetchDataConsumerHandle> handle = createFetchDataConsumerHandleFromWebHandle(createWaitingDataConsumerHandle());
BodyStreamBuffer* buffer = new BodyStreamBuffer(getScriptState(), std::move(handle));
@@ -229,6 +232,7 @@ TEST_F(BodyStreamBufferTest, DrainAsBlobFromBufferMadeFromBufferMadeFromStream)
TEST_F(BodyStreamBufferTest, DrainAsFormData)
{
+ ScriptState::Scope scope(getScriptState());
FormData* data = FormData::create(UTF8Encoding());
data->append("name1", "value1");
data->append("name2", "value2");
@@ -249,6 +253,7 @@ TEST_F(BodyStreamBufferTest, DrainAsFormData)
TEST_F(BodyStreamBufferTest, DrainAsFormDataReturnsNull)
{
+ ScriptState::Scope scope(getScriptState());
// This handle is not drainable.
std::unique_ptr<FetchDataConsumerHandle> handle = createFetchDataConsumerHandleFromWebHandle(createWaitingDataConsumerHandle());
BodyStreamBuffer* buffer = new BodyStreamBuffer(getScriptState(), std::move(handle));
@@ -285,6 +290,7 @@ TEST_F(BodyStreamBufferTest, DrainAsFormDataFromBufferMadeFromBufferMadeFromStre
TEST_F(BodyStreamBufferTest, LoadBodyStreamBufferAsArrayBuffer)
{
+ ScriptState::Scope scope(getScriptState());
Checkpoint checkpoint;
MockFetchDataLoaderClient* client = MockFetchDataLoaderClient::create();
DOMArrayBuffer* arrayBuffer = nullptr;
@@ -317,6 +323,7 @@ TEST_F(BodyStreamBufferTest, LoadBodyStreamBufferAsArrayBuffer)
TEST_F(BodyStreamBufferTest, LoadBodyStreamBufferAsBlob)
{
+ ScriptState::Scope scope(getScriptState());
Checkpoint checkpoint;
MockFetchDataLoaderClient* client = MockFetchDataLoaderClient::create();
RefPtr<BlobDataHandle> blobDataHandle;
@@ -348,6 +355,7 @@ TEST_F(BodyStreamBufferTest, LoadBodyStreamBufferAsBlob)
TEST_F(BodyStreamBufferTest, LoadBodyStreamBufferAsString)
{
+ ScriptState::Scope scope(getScriptState());
Checkpoint checkpoint;
MockFetchDataLoaderClient* client = MockFetchDataLoaderClient::create();
@@ -377,6 +385,7 @@ TEST_F(BodyStreamBufferTest, LoadBodyStreamBufferAsString)
TEST_F(BodyStreamBufferTest, LoadClosedHandle)
{
+ ScriptState::Scope scope(getScriptState());
Checkpoint checkpoint;
MockFetchDataLoaderClient* client = MockFetchDataLoaderClient::create();
@@ -411,6 +420,7 @@ TEST_F(BodyStreamBufferTest, LoadClosedHandle)
TEST_F(BodyStreamBufferTest, LoadErroredHandle)
{
+ ScriptState::Scope scope(getScriptState());
Checkpoint checkpoint;
MockFetchDataLoaderClient* client = MockFetchDataLoaderClient::create();
@@ -444,6 +454,7 @@ TEST_F(BodyStreamBufferTest, LoadErroredHandle)
TEST_F(BodyStreamBufferTest, LoaderShouldBeKeptAliveByBodyStreamBuffer)
{
+ ScriptState::Scope scope(getScriptState());
Checkpoint checkpoint;
MockFetchDataLoaderClient* client = MockFetchDataLoaderClient::create();

Powered by Google App Engine
This is Rietveld 408576698