Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Side by Side Diff: third_party/WebKit/Source/modules/fetch/RequestTest.cpp

Issue 2141383002: [Fetch API] Remove HandleScope to protect local handles (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "modules/fetch/Request.h" 5 #include "modules/fetch/Request.h"
6 6
7 #include "bindings/core/v8/ExceptionState.h" 7 #include "bindings/core/v8/ExceptionState.h"
8 #include "bindings/core/v8/ScriptState.h" 8 #include "bindings/core/v8/ScriptState.h"
9 #include "bindings/core/v8/V8BindingForTesting.h"
9 #include "core/dom/Document.h" 10 #include "core/dom/Document.h"
10 #include "core/frame/Frame.h"
11 #include "core/testing/DummyPageHolder.h"
12 #include "public/platform/WebURLRequest.h" 11 #include "public/platform/WebURLRequest.h"
13 #include "public/platform/modules/serviceworker/WebServiceWorkerRequest.h" 12 #include "public/platform/modules/serviceworker/WebServiceWorkerRequest.h"
14 #include "testing/gtest/include/gtest/gtest.h" 13 #include "testing/gtest/include/gtest/gtest.h"
15 #include "wtf/HashMap.h" 14 #include "wtf/HashMap.h"
16 #include "wtf/text/WTFString.h" 15 #include "wtf/text/WTFString.h"
17 #include <memory> 16 #include <memory>
18 17
19 namespace blink { 18 namespace blink {
20 namespace { 19 namespace {
21 20
22 class ServiceWorkerRequestTest : public ::testing::Test { 21 TEST(ServiceWorkerRequestTest, FromString)
23 public:
24 ServiceWorkerRequestTest()
25 : m_page(DummyPageHolder::create(IntSize(1, 1))) { }
26
27 ScriptState* getScriptState() { return ScriptState::forMainWorld(m_page->doc ument().frame()); }
28 ExecutionContext* getExecutionContext() { return getScriptState()->getExecut ionContext(); }
29
30 private:
31 std::unique_ptr<DummyPageHolder> m_page;
32 };
33
34 TEST_F(ServiceWorkerRequestTest, FromString)
35 { 22 {
23 V8TestingScope scope;
36 TrackExceptionState exceptionState; 24 TrackExceptionState exceptionState;
37 25
38 KURL url(ParsedURLString, "http://www.example.com/"); 26 KURL url(ParsedURLString, "http://www.example.com/");
39 Request* request = Request::create(getScriptState(), url, exceptionState); 27 Request* request = Request::create(scope.getScriptState(), url, exceptionSta te);
40 ASSERT_FALSE(exceptionState.hadException()); 28 ASSERT_FALSE(exceptionState.hadException());
41 ASSERT(request); 29 ASSERT(request);
42 EXPECT_EQ(url, request->url()); 30 EXPECT_EQ(url, request->url());
43 } 31 }
44 32
45 TEST_F(ServiceWorkerRequestTest, FromRequest) 33 TEST(ServiceWorkerRequestTest, FromRequest)
46 { 34 {
35 V8TestingScope scope;
47 TrackExceptionState exceptionState; 36 TrackExceptionState exceptionState;
48 37
49 KURL url(ParsedURLString, "http://www.example.com/"); 38 KURL url(ParsedURLString, "http://www.example.com/");
50 Request* request1 = Request::create(getScriptState(), url, exceptionState); 39 Request* request1 = Request::create(scope.getScriptState(), url, exceptionSt ate);
51 ASSERT(request1); 40 ASSERT(request1);
52 41
53 Request* request2 = Request::create(getScriptState(), request1, exceptionSta te); 42 Request* request2 = Request::create(scope.getScriptState(), request1, except ionState);
54 ASSERT_FALSE(exceptionState.hadException()); 43 ASSERT_FALSE(exceptionState.hadException());
55 ASSERT(request2); 44 ASSERT(request2);
56 EXPECT_EQ(url, request2->url()); 45 EXPECT_EQ(url, request2->url());
57 } 46 }
58 47
59 TEST_F(ServiceWorkerRequestTest, FromAndToWebRequest) 48 TEST(ServiceWorkerRequestTest, FromAndToWebRequest)
60 { 49 {
50 V8TestingScope scope;
61 WebServiceWorkerRequest webRequest; 51 WebServiceWorkerRequest webRequest;
62 52
63 const KURL url(ParsedURLString, "http://www.example.com/"); 53 const KURL url(ParsedURLString, "http://www.example.com/");
64 const String method = "GET"; 54 const String method = "GET";
65 struct { 55 struct {
66 const char* key; 56 const char* key;
67 const char* value; 57 const char* value;
68 } headers[] = { {"X-Foo", "bar"}, {"X-Quux", "foop"}, {0, 0} }; 58 } headers[] = { {"X-Foo", "bar"}, {"X-Quux", "foop"}, {0, 0} };
69 const String referrer = "http://www.referrer.com/"; 59 const String referrer = "http://www.referrer.com/";
70 const WebReferrerPolicy referrerPolicy = WebReferrerPolicyAlways; 60 const WebReferrerPolicy referrerPolicy = WebReferrerPolicyAlways;
71 const WebURLRequest::RequestContext context = WebURLRequest::RequestContextA udio; 61 const WebURLRequest::RequestContext context = WebURLRequest::RequestContextA udio;
72 const WebURLRequest::FetchRequestMode mode = WebURLRequest::FetchRequestMode Navigate; 62 const WebURLRequest::FetchRequestMode mode = WebURLRequest::FetchRequestMode Navigate;
73 63
74 webRequest.setURL(url); 64 webRequest.setURL(url);
75 webRequest.setMethod(method); 65 webRequest.setMethod(method);
76 webRequest.setRequestContext(context); 66 webRequest.setRequestContext(context);
77 webRequest.setMode(mode); 67 webRequest.setMode(mode);
78 for (int i = 0; headers[i].key; ++i) 68 for (int i = 0; headers[i].key; ++i)
79 webRequest.setHeader(WebString::fromUTF8(headers[i].key), WebString::fro mUTF8(headers[i].value)); 69 webRequest.setHeader(WebString::fromUTF8(headers[i].key), WebString::fro mUTF8(headers[i].value));
80 webRequest.setReferrer(referrer, referrerPolicy); 70 webRequest.setReferrer(referrer, referrerPolicy);
81 71
82 Request* request = Request::create(getScriptState(), webRequest); 72 Request* request = Request::create(scope.getScriptState(), webRequest);
83 ASSERT(request); 73 ASSERT(request);
84 EXPECT_EQ(url, request->url()); 74 EXPECT_EQ(url, request->url());
85 EXPECT_EQ(method, request->method()); 75 EXPECT_EQ(method, request->method());
86 EXPECT_EQ("audio", request->context()); 76 EXPECT_EQ("audio", request->context());
87 EXPECT_EQ(referrer, request->referrer()); 77 EXPECT_EQ(referrer, request->referrer());
88 EXPECT_EQ("navigate", request->mode()); 78 EXPECT_EQ("navigate", request->mode());
89 79
90 Headers* requestHeaders = request->getHeaders(); 80 Headers* requestHeaders = request->getHeaders();
91 81
92 WTF::HashMap<String, String> headersMap; 82 WTF::HashMap<String, String> headersMap;
(...skipping 10 matching lines...) Expand all
103 request->populateWebServiceWorkerRequest(secondWebRequest); 93 request->populateWebServiceWorkerRequest(secondWebRequest);
104 EXPECT_EQ(url, KURL(secondWebRequest.url())); 94 EXPECT_EQ(url, KURL(secondWebRequest.url()));
105 EXPECT_EQ(method, String(secondWebRequest.method())); 95 EXPECT_EQ(method, String(secondWebRequest.method()));
106 EXPECT_EQ(context, secondWebRequest.requestContext()); 96 EXPECT_EQ(context, secondWebRequest.requestContext());
107 EXPECT_EQ(referrer, KURL(secondWebRequest.referrerUrl())); 97 EXPECT_EQ(referrer, KURL(secondWebRequest.referrerUrl()));
108 EXPECT_EQ(WebReferrerPolicyAlways, secondWebRequest.referrerPolicy()); 98 EXPECT_EQ(WebReferrerPolicyAlways, secondWebRequest.referrerPolicy());
109 EXPECT_EQ(webRequest.headers(), secondWebRequest.headers()); 99 EXPECT_EQ(webRequest.headers(), secondWebRequest.headers());
110 EXPECT_EQ(WebURLRequest::FetchRequestModeNoCORS, secondWebRequest.mode()); 100 EXPECT_EQ(WebURLRequest::FetchRequestModeNoCORS, secondWebRequest.mode());
111 } 101 }
112 102
113 TEST_F(ServiceWorkerRequestTest, ToWebRequestStripsURLFragment) 103 TEST(ServiceWorkerRequestTest, ToWebRequestStripsURLFragment)
114 { 104 {
105 V8TestingScope scope;
115 TrackExceptionState exceptionState; 106 TrackExceptionState exceptionState;
116 String urlWithoutFragment = "http://www.example.com/"; 107 String urlWithoutFragment = "http://www.example.com/";
117 String url = urlWithoutFragment + "#fragment"; 108 String url = urlWithoutFragment + "#fragment";
118 Request* request = Request::create(getScriptState(), url, exceptionState); 109 Request* request = Request::create(scope.getScriptState(), url, exceptionSta te);
119 ASSERT(request); 110 ASSERT(request);
120 111
121 WebServiceWorkerRequest webRequest; 112 WebServiceWorkerRequest webRequest;
122 request->populateWebServiceWorkerRequest(webRequest); 113 request->populateWebServiceWorkerRequest(webRequest);
123 EXPECT_EQ(urlWithoutFragment, KURL(webRequest.url())); 114 EXPECT_EQ(urlWithoutFragment, KURL(webRequest.url()));
124 } 115 }
125 116
126 } // namespace 117 } // namespace
127 } // namespace blink 118 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/modules/fetch/Request.cpp ('k') | third_party/WebKit/Source/modules/fetch/Response.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698