[Fetch API] Remove HandleScope to protect local handles

third_party/WebKit/Source/modules/fetch/FetchManager.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "modules/fetch/FetchManager.h"
 
 #include "bindings/core/v8/ExceptionState.h"
 #include "bindings/core/v8/ScriptPromiseResolver.h"
 #include "bindings/core/v8/ScriptState.h"
 #include "bindings/core/v8/V8ThrowException.h"
@@ skipping 125 matching lines @@
 
         DEFINE_INLINE_TRACE()
         {
             visitor->trace(m_updater);
             visitor->trace(m_response);
             visitor->trace(m_loader);
         }
     private:
         std::unique_ptr<WebDataConsumerHandle> m_handle;
         Member<CompositeDataConsumerHandle::Updater> m_updater;
+        // We cannot store a Response because its JS wrapper can be collected.
+        // TODO(yhirano): Fix this.
         Member<Response> m_response;
         Member<FetchManager::Loader> m_loader;
         String m_integrityMetadata;
         KURL m_url;
         std::unique_ptr<WebDataConsumerHandle::Reader> m_reader;
         Vector<char> m_buffer;
         bool m_finished;
     };
 
 private:
@@ skipping 46 matching lines @@
     visitor->trace(m_fetchManager);
     visitor->trace(m_resolver);
     visitor->trace(m_request);
     visitor->trace(m_integrityVerifier);
     visitor->trace(m_executionContext);
 }
 
 void FetchManager::Loader::didReceiveResponse(unsigned long, const ResourceResponse& response, std::unique_ptr<WebDataConsumerHandle> handle)
 {
     ASSERT(handle);
+    ScriptState* scriptState = m_resolver->getScriptState();
+    ScriptState::Scope scope(scriptState);
 
     if (response.url().protocolIs("blob") && response.httpStatusCode() == 404) {
         // "If |blob| is null, return a network error."
         // https://fetch.spec.whatwg.org/#concept-basic-fetch
         performNetworkError("Blob not found.");
         return;
     }
 
     if (response.url().protocolIs("blob") && response.httpStatusCode() == 405) {
         performNetworkError("Only 'GET' method is allowed for blob URLs.");
@@ skipping 61 matching lines @@
             // opaque redirect response.
         case WebServiceWorkerResponseTypeError:
             // When ServiceWorker respond to the request from fetch() with an
             // error response, FetchManager::Loader::didFail() must be called
             // instead.
             RELEASE_NOTREACHED();
             break;
         }
     }
 
-    ScriptState* scriptState = m_resolver->getScriptState();
     FetchResponseData* responseData = nullptr;
     CompositeDataConsumerHandle::Updater* updater = nullptr;
     if (m_request->integrity().isEmpty())
         responseData = FetchResponseData::createWithBuffer(new BodyStreamBuffer(scriptState, createFetchDataConsumerHandleFromWebHandle(std::move(handle))));
     else
         responseData = FetchResponseData::createWithBuffer(new BodyStreamBuffer(scriptState, createFetchDataConsumerHandleFromWebHandle(CompositeDataConsumerHandle::create(createWaitingDataConsumerHandle(), &updater))));
     responseData->setStatus(response.httpStatusCode());
     responseData->setStatusMessage(response.httpStatusText());
     for (auto& it : response.httpHeaderFields())
         responseData->headerList()->append(it.key, it.value);
@@ skipping 434 matching lines @@
     loader->dispose();
 }
 
 DEFINE_TRACE(FetchManager)
 {
     visitor->trace(m_loaders);
     ContextLifecycleObserver::trace(visitor);
 }
 
 } // namespace blink