[Fetch API] Remove HandleScope to protect local handles

third_party/WebKit/Source/modules/fetch/ResponseTest.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "modules/fetch/Response.h"
 
 #include "bindings/core/v8/ExceptionState.h"
 #include "bindings/core/v8/ScriptState.h"
+#include "bindings/core/v8/V8BindingForTesting.h"
 #include "core/dom/Document.h"
 #include "core/frame/Frame.h"
 #include "core/testing/DummyPageHolder.h"
 #include "modules/fetch/BodyStreamBuffer.h"
 #include "modules/fetch/DataConsumerHandleTestUtil.h"
 #include "modules/fetch/DataConsumerHandleUtil.h"
 #include "modules/fetch/FetchResponseData.h"
 #include "platform/blob/BlobData.h"
 #include "platform/testing/UnitTestHelpers.h"
 #include "public/platform/modules/serviceworker/WebServiceWorkerResponse.h"
@@ skipping 17 matching lines @@
     std::unique_ptr<WebServiceWorkerResponse> webResponse = wrapUnique(new WebServiceWorkerResponse());
     webResponse->setURL(url);
     webResponse->setStatus(status);
     webResponse->setStatusText(statusText);
     webResponse->setResponseType(WebServiceWorkerResponseTypeDefault);
     for (int i = 0; headers[i].key; ++i)
         webResponse->setHeader(WebString::fromUTF8(headers[i].key), WebString::fromUTF8(headers[i].value));
     return webResponse;
 }
 
-class ServiceWorkerResponseTest : public ::testing::Test {
-public:
-    ServiceWorkerResponseTest()
-        : m_page(DummyPageHolder::create(IntSize(1, 1))) { }
-
-    ScriptState* getScriptState() { return ScriptState::forMainWorld(m_page->document().frame()); }
-    ExecutionContext* getExecutionContext() { return getScriptState()->getExecutionContext(); }
-
-private:
-    std::unique_ptr<DummyPageHolder> m_page;
-};
-
-
-TEST_F(ServiceWorkerResponseTest, FromFetchResponseData)
+TEST(ServiceWorkerResponseTest, FromFetchResponseData)
 {
+    std::unique_ptr<DummyPageHolder> page = DummyPageHolder::create(IntSize(1, 1));
     const KURL url(ParsedURLString, "http://www.response.com");
 
     FetchResponseData* fetchResponseData = FetchResponseData::create();
     fetchResponseData->setURL(url);
 
-    Response* response = Response::create(getExecutionContext(), fetchResponseData);
+    Response* response = Response::create(&page->document(), fetchResponseData);
     ASSERT(response);
     EXPECT_EQ(url, response->url());
 }
 
-TEST_F(ServiceWorkerResponseTest, FromWebServiceWorkerResponse)
+TEST(ServiceWorkerResponseTest, FromWebServiceWorkerResponse)
 {
+    V8TestingScope scope;
     std::unique_ptr<WebServiceWorkerResponse> webResponse = createTestWebServiceWorkerResponse();
-    Response* response = Response::create(getScriptState(), *webResponse);
+    Response* response = Response::create(scope.getScriptState(), *webResponse);
     ASSERT(response);
     EXPECT_EQ(webResponse->url(), response->url());
     EXPECT_EQ(webResponse->status(), response->status());
     EXPECT_STREQ(webResponse->statusText().utf8().c_str(), response->statusText().utf8().data());
 
     Headers* responseHeaders = response->headers();
 
     WebVector<WebString> keys = webResponse->getHeaderKeys();
     EXPECT_EQ(keys.size(), responseHeaders->headerList()->size());
     for (size_t i = 0, max = keys.size(); i < max; ++i) {
         WebString key = keys[i];
         TrackExceptionState exceptionState;
         EXPECT_STREQ(webResponse->getHeader(key).utf8().c_str(), responseHeaders->get(key, exceptionState).utf8().data());
         EXPECT_FALSE(exceptionState.hadException());
     }
 }
 
-TEST_F(ServiceWorkerResponseTest, FromWebServiceWorkerResponseDefault)
+TEST(ServiceWorkerResponseTest, FromWebServiceWorkerResponseDefault)
 {
+    V8TestingScope scope;
     std::unique_ptr<WebServiceWorkerResponse> webResponse = createTestWebServiceWorkerResponse();
     webResponse->setResponseType(WebServiceWorkerResponseTypeDefault);
-    Response* response = Response::create(getScriptState(), *webResponse);
+    Response* response = Response::create(scope.getScriptState(), *webResponse);
 
     Headers* responseHeaders = response->headers();
     TrackExceptionState exceptionState;
     EXPECT_STREQ("foop", responseHeaders->get("set-cookie", exceptionState).utf8().data());
     EXPECT_STREQ("bar", responseHeaders->get("foo", exceptionState).utf8().data());
     EXPECT_STREQ("no-cache", responseHeaders->get("cache-control", exceptionState).utf8().data());
     EXPECT_FALSE(exceptionState.hadException());
 }
 
-TEST_F(ServiceWorkerResponseTest, FromWebServiceWorkerResponseBasic)
+TEST(ServiceWorkerResponseTest, FromWebServiceWorkerResponseBasic)
 {
+    V8TestingScope scope;
     std::unique_ptr<WebServiceWorkerResponse> webResponse = createTestWebServiceWorkerResponse();
     webResponse->setResponseType(WebServiceWorkerResponseTypeBasic);
-    Response* response = Response::create(getScriptState(), *webResponse);
+    Response* response = Response::create(scope.getScriptState(), *webResponse);
 
     Headers* responseHeaders = response->headers();
     TrackExceptionState exceptionState;
     EXPECT_STREQ("", responseHeaders->get("set-cookie", exceptionState).utf8().data());
     EXPECT_STREQ("bar", responseHeaders->get("foo", exceptionState).utf8().data());
     EXPECT_STREQ("no-cache", responseHeaders->get("cache-control", exceptionState).utf8().data());
     EXPECT_FALSE(exceptionState.hadException());
 }
 
-TEST_F(ServiceWorkerResponseTest, FromWebServiceWorkerResponseCORS)
+TEST(ServiceWorkerResponseTest, FromWebServiceWorkerResponseCORS)
 {
+    V8TestingScope scope;
     std::unique_ptr<WebServiceWorkerResponse> webResponse = createTestWebServiceWorkerResponse();
     webResponse->setResponseType(WebServiceWorkerResponseTypeCORS);
-    Response* response = Response::create(getScriptState(), *webResponse);
+    Response* response = Response::create(scope.getScriptState(), *webResponse);
 
     Headers* responseHeaders = response->headers();
     TrackExceptionState exceptionState;
     EXPECT_STREQ("", responseHeaders->get("set-cookie", exceptionState).utf8().data());
     EXPECT_STREQ("", responseHeaders->get("foo", exceptionState).utf8().data());
     EXPECT_STREQ("no-cache", responseHeaders->get("cache-control", exceptionState).utf8().data());
     EXPECT_FALSE(exceptionState.hadException());
 }
 
-TEST_F(ServiceWorkerResponseTest, FromWebServiceWorkerResponseOpaque)
+TEST(ServiceWorkerResponseTest, FromWebServiceWorkerResponseOpaque)
 {
+    V8TestingScope scope;
     std::unique_ptr<WebServiceWorkerResponse> webResponse = createTestWebServiceWorkerResponse();
     webResponse->setResponseType(WebServiceWorkerResponseTypeOpaque);
-    Response* response = Response::create(getScriptState(), *webResponse);
+    Response* response = Response::create(scope.getScriptState(), *webResponse);
 
     Headers* responseHeaders = response->headers();
     TrackExceptionState exceptionState;
     EXPECT_STREQ("", responseHeaders->get("set-cookie", exceptionState).utf8().data());
     EXPECT_STREQ("", responseHeaders->get("foo", exceptionState).utf8().data());
     EXPECT_STREQ("", responseHeaders->get("cache-control", exceptionState).utf8().data());
     EXPECT_FALSE(exceptionState.hadException());
 }
 
 void checkResponseStream(ScriptState* scriptState, Response* response, bool checkResponseBodyStreamBuffer)
@@ skipping 40 matching lines @@
 BodyStreamBuffer* createHelloWorldBuffer(ScriptState* scriptState)
 {
     using Command = DataConsumerHandleTestUtil::Command;
     std::unique_ptr<DataConsumerHandleTestUtil::ReplayingHandle> src(DataConsumerHandleTestUtil::ReplayingHandle::create());
     src->add(Command(Command::Data, "Hello, "));
     src->add(Command(Command::Data, "world"));
     src->add(Command(Command::Done));
     return new BodyStreamBuffer(scriptState, createFetchDataConsumerHandleFromWebHandle(std::move(src)));
 }
 
-TEST_F(ServiceWorkerResponseTest, BodyStreamBufferCloneDefault)
+TEST(ServiceWorkerResponseTest, BodyStreamBufferCloneDefault)
 {
-    BodyStreamBuffer* buffer = createHelloWorldBuffer(getScriptState());
+    V8TestingScope scope;
+    BodyStreamBuffer* buffer = createHelloWorldBuffer(scope.getScriptState());
     FetchResponseData* fetchResponseData = FetchResponseData::createWithBuffer(buffer);
     fetchResponseData->setURL(KURL(ParsedURLString, "http://www.response.com"));
-    Response* response = Response::create(getExecutionContext(), fetchResponseData);
+    Response* response = Response::create(scope.getExecutionContext(), fetchResponseData);
     EXPECT_EQ(response->internalBodyBuffer(), buffer);
-    checkResponseStream(getScriptState(), response, true);
+    checkResponseStream(scope.getScriptState(), response, true);
 }
 
-TEST_F(ServiceWorkerResponseTest, BodyStreamBufferCloneBasic)
+TEST(ServiceWorkerResponseTest, BodyStreamBufferCloneBasic)
 {
-    BodyStreamBuffer* buffer = createHelloWorldBuffer(getScriptState());
+    V8TestingScope scope;
+    BodyStreamBuffer* buffer = createHelloWorldBuffer(scope.getScriptState());
     FetchResponseData* fetchResponseData = FetchResponseData::createWithBuffer(buffer);
     fetchResponseData->setURL(KURL(ParsedURLString, "http://www.response.com"));
     fetchResponseData = fetchResponseData->createBasicFilteredResponse();
-    Response* response = Response::create(getExecutionContext(), fetchResponseData);
+    Response* response = Response::create(scope.getExecutionContext(), fetchResponseData);
     EXPECT_EQ(response->internalBodyBuffer(), buffer);
-    checkResponseStream(getScriptState(), response, true);
+    checkResponseStream(scope.getScriptState(), response, true);
 }
 
-TEST_F(ServiceWorkerResponseTest, BodyStreamBufferCloneCORS)
+TEST(ServiceWorkerResponseTest, BodyStreamBufferCloneCORS)
 {
-    BodyStreamBuffer* buffer = createHelloWorldBuffer(getScriptState());
+    V8TestingScope scope;
+    BodyStreamBuffer* buffer = createHelloWorldBuffer(scope.getScriptState());
     FetchResponseData* fetchResponseData = FetchResponseData::createWithBuffer(buffer);
     fetchResponseData->setURL(KURL(ParsedURLString, "http://www.response.com"));
     fetchResponseData = fetchResponseData->createCORSFilteredResponse();
-    Response* response = Response::create(getExecutionContext(), fetchResponseData);
+    Response* response = Response::create(scope.getExecutionContext(), fetchResponseData);
     EXPECT_EQ(response->internalBodyBuffer(), buffer);
-    checkResponseStream(getScriptState(), response, true);
+    checkResponseStream(scope.getScriptState(), response, true);
 }
 
-TEST_F(ServiceWorkerResponseTest, BodyStreamBufferCloneOpaque)
+TEST(ServiceWorkerResponseTest, BodyStreamBufferCloneOpaque)
 {
-    BodyStreamBuffer* buffer = createHelloWorldBuffer(getScriptState());
+    V8TestingScope scope;
+    BodyStreamBuffer* buffer = createHelloWorldBuffer(scope.getScriptState());
     FetchResponseData* fetchResponseData = FetchResponseData::createWithBuffer(buffer);
     fetchResponseData->setURL(KURL(ParsedURLString, "http://www.response.com"));
     fetchResponseData = fetchResponseData->createOpaqueFilteredResponse();
-    Response* response = Response::create(getExecutionContext(), fetchResponseData);
+    Response* response = Response::create(scope.getExecutionContext(), fetchResponseData);
     EXPECT_EQ(response->internalBodyBuffer(), buffer);
-    checkResponseStream(getScriptState(), response, false);
+    checkResponseStream(scope.getScriptState(), response, false);
 }
 
-TEST_F(ServiceWorkerResponseTest, BodyStreamBufferCloneError)
+TEST(ServiceWorkerResponseTest, BodyStreamBufferCloneError)
 {
-    BodyStreamBuffer* buffer = new BodyStreamBuffer(getScriptState(), createFetchDataConsumerHandleFromWebHandle(createUnexpectedErrorDataConsumerHandle()));
+    V8TestingScope scope;
+    BodyStreamBuffer* buffer = new BodyStreamBuffer(scope.getScriptState(), createFetchDataConsumerHandleFromWebHandle(createUnexpectedErrorDataConsumerHandle()));
     FetchResponseData* fetchResponseData = FetchResponseData::createWithBuffer(buffer);
     fetchResponseData->setURL(KURL(ParsedURLString, "http://www.response.com"));
-    Response* response = Response::create(getExecutionContext(), fetchResponseData);
+    Response* response = Response::create(scope.getExecutionContext(), fetchResponseData);
     TrackExceptionState exceptionState;
-    Response* clonedResponse = response->clone(getScriptState(), exceptionState);
+    Response* clonedResponse = response->clone(scope.getScriptState(), exceptionState);
     EXPECT_FALSE(exceptionState.hadException());
 
     DataConsumerHandleTestUtil::MockFetchDataLoaderClient* client1 = new DataConsumerHandleTestUtil::MockFetchDataLoaderClient();
     DataConsumerHandleTestUtil::MockFetchDataLoaderClient* client2 = new DataConsumerHandleTestUtil::MockFetchDataLoaderClient();
     EXPECT_CALL(*client1, didFetchDataLoadFailed());
     EXPECT_CALL(*client2, didFetchDataLoadFailed());
 
     response->internalBodyBuffer()->startLoading(FetchDataLoader::createLoaderAsString(), client1);
     clonedResponse->internalBodyBuffer()->startLoading(FetchDataLoader::createLoaderAsString(), client2);
     blink::testing::runPendingTasks();
 }
 
 } // namespace
 } // namespace blink