Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Issue 2141373002: file_manager: Do not return ARC tasks if a directory is selected (Closed)

Created:
4 years, 5 months ago by hashimoto
Modified:
4 years, 5 months ago
Reviewers:
kinaba
CC:
chromium-reviews, rginda+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

file_manager: Do not return ARC tasks if a directory is selected When the selection includes a directory, no ARC tasks should be returned. BUG=627679 TEST=Cannot open a directory with ARC apps Committed: https://crrev.com/4699a16ee722fae35760559e179c7a4f8a53b1f0 Cr-Commit-Position: refs/heads/master@{#405075}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M chrome/browser/chromeos/file_manager/arc_file_tasks.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
hashimoto
4 years, 5 months ago (2016-07-13 07:11:39 UTC) #3
kinaba
lgtm
4 years, 5 months ago (2016-07-13 07:12:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2141373002/1
4 years, 5 months ago (2016-07-13 07:47:26 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-13 08:05:01 UTC) #8
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-13 08:05:13 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 08:08:21 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4699a16ee722fae35760559e179c7a4f8a53b1f0
Cr-Commit-Position: refs/heads/master@{#405075}

Powered by Google App Engine
This is Rietveld 408576698