Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 214133006: Remember what branches we delete and do not try to reparent them in cleanup. (Closed)

Created:
6 years, 9 months ago by iannucci
Modified:
6 years, 8 months ago
Reviewers:
agable
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Visibility:
Public.

Description

Remember what branches we delete and do not try to reparent them in cleanup. R=agable@chromium.org BUG=357367 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=260704

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M git_rebase_update.py View 3 chunks +5 lines, -0 lines 0 comments Download
M tests/git_rebase_update_test.py View 2 chunks +5 lines, -0 lines 1 comment Download

Messages

Total messages: 6 (0 generated)
iannucci
6 years, 9 months ago (2014-03-28 23:14:36 UTC) #1
agable
LGTM https://codereview.chromium.org/214133006/diff/1/tests/git_rebase_update_test.py File tests/git_rebase_update_test.py (right): https://codereview.chromium.org/214133006/diff/1/tests/git_rebase_update_test.py#newcode133 tests/git_rebase_update_test.py:133: self.assertIn('Deleted branch empty_branch2', output) See today's ToT: Would ...
6 years, 8 months ago (2014-03-29 00:02:04 UTC) #2
iannucci
On 2014/03/29 00:02:04, agable wrote: > LGTM > > https://codereview.chromium.org/214133006/diff/1/tests/git_rebase_update_test.py > File tests/git_rebase_update_test.py (right): > ...
6 years, 8 months ago (2014-03-31 23:33:47 UTC) #3
iannucci
The CQ bit was checked by iannucci@chromium.org
6 years, 8 months ago (2014-03-31 23:34:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/iannucci@chromium.org/214133006/1
6 years, 8 months ago (2014-03-31 23:34:16 UTC) #5
commit-bot: I haz the power
6 years, 8 months ago (2014-03-31 23:36:11 UTC) #6
Message was sent while issue was closed.
Change committed as 260704

Powered by Google App Engine
This is Rietveld 408576698