chrome/browser/resources/settings/settings_resources.grd - Issue 2141313002: Settings Router Refactor: Implement new Route class w/ test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/settings_resources.grd

Issue 2141313002: Settings Router Refactor: Implement new Route class w/ test (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/settings/settings_page/settings_router.html ('K') | « chrome/browser/resources/settings/settings_page/settings_router.html ('k') | chrome/test/data/webui/settings/router_tests.js » ('j') | chrome/test/data/webui/settings/router_tests.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/settings_resources.grd

diff --git a/chrome/browser/resources/settings/settings_resources.grd b/chrome/browser/resources/settings/settings_resources.grd

index 38fb84a90f1b848b81fc4c43094da65ef1d36887..507432db15d2edf257d931add08d8a28658f3e78 100644

--- a/chrome/browser/resources/settings/settings_resources.grd

+++ b/chrome/browser/resources/settings/settings_resources.grd

@@ -647,6 +647,14 @@

file="privacy_page/privacy_page_browser_proxy.js"

type="chrome_html" />

</if>

+ <structure name="IDR_SETTINGS_SETTINGS_ROUTE_HTML"

+ file="settings_page/route.html"

+ type="chrome_html" />

+ <structure name="IDR_SETTINGS_SETTINGS_ROUTE_JS"

+ file="settings_page/route.js"

+ type="chrome_html"

+ flattenhtml="true"

michaelpg 2016/07/13 05:53:39 do you need this?

tommycli 2016/07/13 17:45:03 Done.

+ allowexternalscript="true" />

michaelpg 2016/07/13 05:53:39 ditto

tommycli 2016/07/13 17:45:03 Done.

<structure name="IDR_SETTINGS_CR_SETTINGS_ROUTER_HTML"

file="settings_page/settings_router.html"

type="chrome_html" />