chrome/browser/resources/settings/settings_page/route.html - Issue 2141313002: Settings Router Refactor: Implement new Route class w/ test

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/settings/settings_page/route.html

Issue 2141313002: Settings Router Refactor: Implement new Route class w/ test (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/resources/settings/settings_page/compiled_resources2.gyp ('k') | chrome/browser/resources/settings/settings_page/route.js » ('j') | chrome/browser/resources/settings/settings_page/route.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <link rel="import" href="chrome://resources/html/cr.html">	1 <link rel="import" href="chrome://resources/html/cr.html">
	michaelpg 2016/07/13 05:53:39 the settings_page dir is getting big, and I never the settings_page dir is getting big, and I never really got why the router fit with the other stuff since it isn't a page or part of a page. perhaps we should create a directory first for the router stuff and move settings_router.* there, and/or create this in that directory too tommycli 2016/07/13 17:45:03 Done. I moved it to just the root path settings/, Show quoted text On 2016/07/13 05:53:39, michaelpg (slow) wrote: > the settings_page dir is getting big, and I never really got why the router fit > with the other stuff since it isn't a page or part of a page. > > perhaps we should create a directory first for the router stuff and move > settings_router.* there, and/or create this in that directory too Done. I moved it to just the root path settings/, since it's pretty global. settings_router will be removed after this refactor is done, so it didn't seem necessary to create a settings/routes/ directory. Just putting routes.js/html in root dir seemed reasonable.
2 <script src="pref_util.js"></script>	2

	3 <script src="route.js"></script>

OLD	NEW