[Cast for ATV] Enable UMP on Cast for ATV

media/blink/webmediaplayer_impl.h

Index: media/blink/webmediaplayer_impl.h
diff --git a/media/blink/webmediaplayer_impl.h b/media/blink/webmediaplayer_impl.h
index eec234d842100786768dc3b0d8dde65d00bf11c6..a2f553adf7e949e81258702cbc1c27b5c73f8c0a 100644
--- a/media/blink/webmediaplayer_impl.h
+++ b/media/blink/webmediaplayer_impl.h
@@ -233,6 +233,9 @@ class MEDIA_BLINK_EXPORT WebMediaPlayerImpl
  private:
   friend class WebMediaPlayerImplTest;
 
+  void EnableOverlay();
+  void DisableOverlay();

[liberato (no reviews please), 2016/07/18 20:19:58]

EnableOverlay actually allocates the overlay, but DisableOverlay doesn't really
do anything outside of managing the internal state.  in fact, calling
DisableOverlay while a codec is using the overlay might result in weird behavior
-- we won't update its natural size anymore, for example.  the codec might
continue to use the overlay indefinitely, however.

it might be better to include the restart logic in these as well.  i believe
that it's safe -- no restart should happen if we EnableOverlay() before the
codec has requested one (i.e., CreateRenderer).

[AndyWu, 2016/07/18 22:21:49]

Done, thanks a lot.

+
   void OnPipelineSuspended();
   void OnDemuxerOpened();
 
@@ -430,7 +433,7 @@ class MEDIA_BLINK_EXPORT WebMediaPlayerImpl
   // changes.
   bool should_notify_time_changed_;
 
-  bool fullscreen_;
+  bool overlay_enabled_;
 
   // Whether the current decoder requires a restart on fullscreen transitions.
   bool decoder_requires_restart_for_fullscreen_;
@@ -506,14 +509,16 @@ class MEDIA_BLINK_EXPORT WebMediaPlayerImpl
   // For canceling ongoing surface creation requests when exiting fullscreen.
   base::CancelableCallback<void(int)> surface_created_cb_;
 
-  // The current fullscreen surface id. Populated while in fullscreen once the
+  // The current overlay surface id. Populated while in fullscreen once the
   // surface is created.
-  int fullscreen_surface_id_;
+  int overlay_surface_id_;
 
   // If a surface is requested before it's finished being created, the request
   // is saved and satisfied once the surface is available.
   SurfaceCreatedCB pending_surface_request_cb_;
 
+  bool use_overlay_only_;

[liberato (no reviews please), 2016/07/18 20:19:58]

please comment.  also, since it's just a cached copy of the switch, might be
better to name it more similarly to the switch.

[AndyWu, 2016/07/18 22:21:50]

Done, thanks.

+
   // Suppresses calls to OnPipelineError() after destruction / shutdown has been
   // started; prevents us from spuriously logging errors that are transient or
   // unimportant.