[Cast for ATV] Enable UMP on Cast for ATV

media/blink/webmediaplayer_impl.cc

Index: media/blink/webmediaplayer_impl.cc
diff --git a/media/blink/webmediaplayer_impl.cc b/media/blink/webmediaplayer_impl.cc
index c0cdfcc5c25245dd8da65c0ec0c301947fcd5b88..6098dcacb4719d1a2118285dd17ed0499533f3f6 100644
--- a/media/blink/webmediaplayer_impl.cc
+++ b/media/blink/webmediaplayer_impl.cc
@@ -179,7 +179,6 @@ WebMediaPlayerImpl::WebMediaPlayerImpl(
       pending_suspend_resume_cycle_(false),
       ended_(false),
       should_notify_time_changed_(false),
-      fullscreen_(false),
       decoder_requires_restart_for_fullscreen_(false),
       client_(client),
       encrypted_client_(encrypted_client),
@@ -212,6 +211,9 @@ WebMediaPlayerImpl::WebMediaPlayerImpl(
   DCHECK(renderer_factory_);
   DCHECK(client_);
 
+  fullscreen_ = base::CommandLine::ForCurrentProcess()->HasSwitch(
+      switches::kForceMediaPlayerStartingInFullscreenMode);

[halliwell, 2016/07/14 16:37:35]

I'm concerned that what we want on ATV is not technically to be full-screen, we
just want to activate the overlay codepath.

It could be confusing, and could potentially lead to other unwanted behaviour if
there are other side effects of fullscreen mode.

Is it worth doing some renaming/refactoring so that it's clear that we're just
opting in to using overlays?

[liberato (no reviews please), 2016/07/14 16:53:36]

+1, similar to my comment in PS2 -- we shoudln't overload enter/exitFullscreen.

[AndyWu, 2016/07/14 19:02:08]

Totally agree, what we need is overlay codepath, not necessary to be fullscreen.
Rename some variables from "fullscreen" to "overlay".

+
   if (delegate_)
     delegate_id_ = delegate_->AddObserver(this);