[Cast for ATV] Enable UMP on Cast for ATV

media/blink/webmediaplayer_impl.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef MEDIA_BLINK_WEBMEDIAPLAYER_IMPL_H_
 #define MEDIA_BLINK_WEBMEDIAPLAYER_IMPL_H_
 
 #include <stdint.h>
 
 #include <memory>
@@ skipping 215 matching lines @@
   // (Public for testing.)
   struct PlayState {
     DelegateState delegate_state;
     bool is_memory_reporting_enabled;
     bool is_suspended;
   };
 
  private:
   friend class WebMediaPlayerImplTest;
 
+  void EnableOverlay();
+  void DisableOverlay();

[liberato (no reviews please), 2016/07/18 20:19:58]

EnableOverlay actually allocates the overlay, but DisableOverlay doesn't really
do anything outside of managing the internal state.  in fact, calling
DisableOverlay while a codec is using the overlay might result in weird behavior
-- we won't update its natural size anymore, for example.  the codec might
continue to use the overlay indefinitely, however.

it might be better to include the restart logic in these as well.  i believe
that it's safe -- no restart should happen if we EnableOverlay() before the
codec has requested one (i.e., CreateRenderer).

[AndyWu, 2016/07/18 22:21:49]

Done, thanks a lot.

+
   void OnPipelineSuspended();
   void OnDemuxerOpened();
 
   // Pipeline::Client overrides.
   void OnError(PipelineStatus status) override;
   void OnEnded() override;
   void OnMetadata(PipelineMetadata metadata) override;
   void OnBufferingStateChange(BufferingState state) override;
   void OnDurationChange() override;
   void OnAddTextTrack(const TextTrackConfig& config,
@@ skipping 177 matching lines @@
   bool pending_suspend_resume_cycle_;
 
   // TODO(scherkus): Replace with an explicit ended signal to HTMLMediaElement,
   // see http://crbug.com/409280
   bool ended_;
 
   // Tracks whether to issue time changed notifications during buffering state
   // changes.
   bool should_notify_time_changed_;
 
-  bool fullscreen_;
+  bool overlay_enabled_;
 
   // Whether the current decoder requires a restart on fullscreen transitions.
   bool decoder_requires_restart_for_fullscreen_;
 
   blink::WebMediaPlayerClient* client_;
   blink::WebMediaPlayerEncryptedMediaClient* encrypted_client_;
 
   // WebMediaPlayer notifies the |delegate_| of playback state changes using
   // |delegate_id_|; an id provided after registering with the delegate.  The
   // WebMediaPlayer may also receive directives (play, pause) from the delegate
@@ skipping 55 matching lines @@
 
   std::unique_ptr<RendererFactory> renderer_factory_;
 
   // For requesting surfaces on behalf of the Android H/W decoder in fullscreen.
   // This will be null everywhere but Android.
   SurfaceManager* surface_manager_;
 
   // For canceling ongoing surface creation requests when exiting fullscreen.
   base::CancelableCallback<void(int)> surface_created_cb_;
 
-  // The current fullscreen surface id. Populated while in fullscreen once the
+  // The current overlay surface id. Populated while in fullscreen once the
   // surface is created.
-  int fullscreen_surface_id_;
+  int overlay_surface_id_;
 
   // If a surface is requested before it's finished being created, the request
   // is saved and satisfied once the surface is available.
   SurfaceCreatedCB pending_surface_request_cb_;
 
+  bool use_overlay_only_;

[liberato (no reviews please), 2016/07/18 20:19:58]

please comment.  also, since it's just a cached copy of the switch, might be
better to name it more similarly to the switch.

[AndyWu, 2016/07/18 22:21:50]

Done, thanks.

+
   // Suppresses calls to OnPipelineError() after destruction / shutdown has been
   // started; prevents us from spuriously logging errors that are transient or
   // unimportant.
   bool suppress_destruction_errors_;
 
   // State indicating if it's okay to suspend or not. Updated on the first time
   // OnSuspendRequested() is called. If the state is UNKNOWN, the current frame
   // from the compositor will be queried to see if suspend is supported; the
   // state will be set to YES or NO respectively if a frame is available.
   enum class CanSuspendState { UNKNOWN, YES, NO };
   CanSuspendState can_suspend_state_;
 
   // Called some-time after OnHidden() if the media was suspended in a playing
   // state as part of the call to OnHidden().
   base::OneShotTimer background_pause_timer_;
 
   DISALLOW_COPY_AND_ASSIGN(WebMediaPlayerImpl);
 };
 
 }  // namespace media
 
 #endif  // MEDIA_BLINK_WEBMEDIAPLAYER_IMPL_H_