Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Issue 2141283002: Fix git cl set-commit --clear. (Closed)

Created:
4 years, 5 months ago by tandrii(chromium)
Modified:
4 years, 5 months ago
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 : Added tests - show obvious failure #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -6 lines) Patch
M git_cl.py View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/git_cl_test.py View 2 chunks +13 lines, -5 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
tandrii(chromium)
PTAL
4 years, 5 months ago (2016-07-12 23:03:38 UTC) #5
Michael Achenbach
lgtm
4 years, 5 months ago (2016-07-13 09:28:54 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2141283002/20001
4 years, 5 months ago (2016-07-13 09:29:21 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 09:33:02 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/tools/depot_tools/+/d9e5ce518ae6c9...

Powered by Google App Engine
This is Rietveld 408576698