Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 2141263003: Fix clearing compile time constant caches during tree shaking. (Closed)

Created:
4 years, 5 months ago by rmacnak
Modified:
4 years, 5 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix clearing compile time constant caches during tree shaking. The old code was rendered ineffective by the move from per-isolate to per-script caches. R=fschneider@google.com Committed: https://github.com/dart-lang/sdk/commit/8951c3387895c8c99d6843c192429768fa362e61

Patch Set 1 #

Patch Set 2 : whitespace #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -0 lines) Patch
M runtime/vm/precompiler.h View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/precompiler.cc View 1 2 chunks +16 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
rmacnak
4 years, 5 months ago (2016-07-13 17:48:27 UTC) #2
Florian Schneider
lgtm
4 years, 5 months ago (2016-07-13 17:53:49 UTC) #3
rmacnak
4 years, 5 months ago (2016-07-13 18:06:47 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
8951c3387895c8c99d6843c192429768fa362e61 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698