Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issue 2141253004: Revert of Adds associated interface support to IPC::Channel (Closed)

Created:
4 years, 5 months ago by Ken Rockot(use gerrit already)
Modified:
4 years, 5 months ago
Reviewers:
yzshen1
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), darin-cc_chromium.org, jam, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@channel-bindings-1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Adds associated interface support to IPC::Channel (patchset #9 id:160001 of https://codereview.chromium.org/2137353002/ ) Reason for revert: Bah - forgot to update gyp properly. Surprised it got through the CQ... Original issue's description: > Adds associated interface support to IPC::Channel > > Provides a way of registering associated interface bindings with > an IPC::Channel endpoint and acquiring proxies to remote interfaces > on the other side. > > Support for this is exposed by IPC::Channel but only implemented > in IPC::ChannelMojo. > > This is part a series of CLs to support Channel-associated interfaces. > > BUG=612500 > > Committed: https://crrev.com/dc88e5075878f16cde23b910d2ce19aa862129e4 > Cr-Commit-Position: refs/heads/master@{#405316} TBR=yzshen@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=612500 Committed: https://crrev.com/3ab4670d4ce9e922da8e9610eeadde6823bca991 Cr-Commit-Position: refs/heads/master@{#405336}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -319 lines) Patch
M ipc/BUILD.gn View 2 chunks +0 lines, -8 lines 0 comments Download
M ipc/ipc.gyp View 1 chunk +0 lines, -8 lines 0 comments Download
M ipc/ipc.mojom View 1 chunk +0 lines, -6 lines 0 comments Download
M ipc/ipc_channel.h View 3 chunks +0 lines, -65 lines 0 comments Download
M ipc/ipc_channel_common.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M ipc/ipc_channel_mojo.h View 6 chunks +0 lines, -19 lines 0 comments Download
M ipc/ipc_channel_mojo.cc View 3 chunks +0 lines, -30 lines 0 comments Download
M ipc/ipc_channel_mojo_unittest.cc View 9 chunks +9 lines, -126 lines 0 comments Download
M ipc/ipc_message_pipe_reader.h View 4 chunks +1 line, -13 lines 0 comments Download
M ipc/ipc_message_pipe_reader.cc View 2 chunks +0 lines, -16 lines 0 comments Download
M ipc/ipc_mojo_bootstrap.h View 2 chunks +0 lines, -3 lines 0 comments Download
M ipc/ipc_mojo_bootstrap.cc View 3 chunks +0 lines, -11 lines 0 comments Download
D ipc/ipc_test.mojom View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Ken Rockot(use gerrit already)
Created Revert of Adds associated interface support to IPC::Channel
4 years, 5 months ago (2016-07-13 22:59:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2141253004/1
4 years, 5 months ago (2016-07-13 22:59:55 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-13 23:03:20 UTC) #4
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-13 23:03:37 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 23:05:29 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3ab4670d4ce9e922da8e9610eeadde6823bca991
Cr-Commit-Position: refs/heads/master@{#405336}

Powered by Google App Engine
This is Rietveld 408576698