Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1042)

Unified Diff: cc/playback/recording_source.h

Issue 2141233002: cc: Clean up RecordingSource API (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: inline the initialization, constructor/destructor = default in .cc Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/playback/recording_source.h
diff --git a/cc/playback/recording_source.h b/cc/playback/recording_source.h
index 36d0511d358ab2662128f4768900e722e9170d83..8f443425f135cc2af08b6d32f46cb8547120bd1d 100644
--- a/cc/playback/recording_source.h
+++ b/cc/playback/recording_source.h
@@ -70,14 +70,13 @@ class CC_EXPORT RecordingSource {
bool can_use_lcd_text) const;
virtual bool IsSuitableForGpuRasterization() const;
- gfx::Rect recorded_viewport() const { return recorded_viewport_; }
+ gfx::Rect recorded_viewport() const { return inputs_.recorded_viewport; }
const DisplayItemList* GetDisplayItemList();
protected:
void Clear();
- gfx::Rect recorded_viewport_;
gfx::Size size_;
int slow_down_raster_scale_factor_for_debug_;
bool generate_discardable_images_metadata_;
@@ -87,8 +86,17 @@ class CC_EXPORT RecordingSource {
SkColor solid_color_;
SkColor background_color_;
- scoped_refptr<DisplayItemList> display_list_;
- size_t painter_reported_memory_usage_;
+ // Encapsulates all data received from the ContentLayerClient.
+ struct Inputs {
+ Inputs();
+ ~Inputs();
+
+ gfx::Rect recorded_viewport;
+ scoped_refptr<DisplayItemList> display_list;
+ size_t painter_reported_memory_usage = 0;
+ };
+
+ Inputs inputs_;
private:
void UpdateInvalidationForNewViewport(const gfx::Rect& old_recorded_viewport,

Powered by Google App Engine
This is Rietveld 408576698