Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Unified Diff: cc/playback/recording_source.h

Issue 2141233002: cc: Clean up RecordingSource API (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Test code refactor Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/playback/recording_source.h
diff --git a/cc/playback/recording_source.h b/cc/playback/recording_source.h
index 36d0511d358ab2662128f4768900e722e9170d83..e605d8d9dd42017646ec8f9f51a9ee070fb53f59 100644
--- a/cc/playback/recording_source.h
+++ b/cc/playback/recording_source.h
@@ -48,14 +48,15 @@ class CC_EXPORT RecordingSource {
void ToProtobuf(proto::RecordingSource* proto) const;
void FromProtobuf(const proto::RecordingSource& proto,
- ClientPictureCache* client_picture_cache,
- std::vector<uint32_t>* used_engine_picture_ids);
-
- bool UpdateAndExpandInvalidation(ContentLayerClient* painter,
- Region* invalidation,
- const gfx::Size& layer_size,
- int frame_number,
- RecordingMode recording_mode);
+ const scoped_refptr<DisplayItemList>& display_list);
+
+ bool UpdateAndExpandInvalidation(
+ ContentLayerClient* painter,
+ Region* invalidation,
+ const gfx::Size& layer_size,
+ const gfx::Rect& new_recorded_viewport,
+ const scoped_refptr<DisplayItemList>& display_list,
+ const size_t& painter_reported_memory_usage);
gfx::Size GetSize() const;
void SetEmptyBounds();
void SetSlowdownRasterScaleFactor(int factor);
@@ -68,15 +69,10 @@ class CC_EXPORT RecordingSource {
// These functions are virtual for testing.
virtual scoped_refptr<RasterSource> CreateRasterSource(
bool can_use_lcd_text) const;
- virtual bool IsSuitableForGpuRasterization() const;
-
- gfx::Rect recorded_viewport() const { return recorded_viewport_; }
const DisplayItemList* GetDisplayItemList();
protected:
- void Clear();
-
gfx::Rect recorded_viewport_;
gfx::Size size_;
int slow_down_raster_scale_factor_for_debug_;
@@ -86,7 +82,6 @@ class CC_EXPORT RecordingSource {
bool clear_canvas_with_debug_color_;
SkColor solid_color_;
SkColor background_color_;
-
scoped_refptr<DisplayItemList> display_list_;
size_t painter_reported_memory_usage_;
@@ -94,6 +89,7 @@ class CC_EXPORT RecordingSource {
void UpdateInvalidationForNewViewport(const gfx::Rect& old_recorded_viewport,
const gfx::Rect& new_recorded_viewport,
Region* invalidation);
+
void FinishDisplayItemListUpdate();
friend class RasterSource;

Powered by Google App Engine
This is Rietveld 408576698