Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3590)

Unified Diff: cc/layers/picture_layer_unittest.cc

Issue 2141233002: cc: Clean up RecordingSource API (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Test code refactor Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/layers/picture_layer_unittest.cc
diff --git a/cc/layers/picture_layer_unittest.cc b/cc/layers/picture_layer_unittest.cc
index 1a80b597406ab22d53957a835cda6fc3139b5c04..002cbaefa815c6bf0cf3cf66716ae669942f653a 100644
--- a/cc/layers/picture_layer_unittest.cc
+++ b/cc/layers/picture_layer_unittest.cc
@@ -95,12 +95,23 @@ class TestSerializationPictureLayer : public PictureLayer {
EXPECT_EQ(update_source_frame_number_, layer->update_source_frame_number_);
EXPECT_EQ(is_mask_, layer->is_mask_);
EXPECT_EQ(inputs_.nearest_neighbor, layer->inputs_.nearest_neighbor);
+ EXPECT_EQ(inputs_.recorded_viewport, layer->inputs_.recorded_viewport);
+
+ // The DisplayItemLists are equal if they are both null or they are both not
+ // null and render to the same thing.
+ bool display_lists_equal =
+ !inputs_.display_list && !layer->inputs_.display_list;
+ if (inputs_.display_list && layer->inputs_.display_list) {
+ display_lists_equal = AreDisplayListDrawingResultsSame(
+ inputs_.recorded_viewport, inputs_.display_list.get(),
+ layer->inputs_.display_list.get());
+ }
+ EXPECT_EQ(display_lists_equal, true);
vmpstr 2016/07/27 18:18:37 EXPECT_TRUE(dispay_lists_equal)
Menglin 2016/07/29 23:50:14 Done.
}
std::vector<uint32_t> GetPictureIds() {
std::vector<uint32_t> ids;
- const DisplayItemList* display_list =
- recording_source()->GetDisplayItemList();
+ const DisplayItemList* display_list = inputs_.display_list.get();
if (!display_list)
return ids;
@@ -444,16 +455,22 @@ TEST(PictureLayerTest, SuitableForGpuRasterization) {
gfx::Size layer_bounds(200, 200);
gfx::Rect layer_rect(layer_bounds);
Region invalidation(layer_rect);
+
+ gfx::Rect new_recorded_viewport = client->PaintableRegion();
+ scoped_refptr<DisplayItemList> display_list =
+ client->PaintContentsToDisplayList(
+ ContentLayerClient::PAINTING_BEHAVIOR_NORMAL);
+ size_t painter_reported_memory_usage =
+ client->GetApproximateUnsharedMemoryUsage();
recording_source->UpdateAndExpandInvalidation(
- client, &invalidation, layer_bounds, 1, RecordingSource::RECORD_NORMALLY);
+ client, &invalidation, layer_bounds, new_recorded_viewport, display_list,
+ painter_reported_memory_usage);
// Layer is suitable for gpu rasterization by default.
- EXPECT_TRUE(recording_source->IsSuitableForGpuRasterization());
EXPECT_TRUE(layer->IsSuitableForGpuRasterization());
// Veto gpu rasterization.
- recording_source->SetForceUnsuitableForGpuRasterization(true);
- EXPECT_FALSE(recording_source->IsSuitableForGpuRasterization());
+ layer->SetForceUnsuitableForGpuRasterization(true);
EXPECT_FALSE(layer->IsSuitableForGpuRasterization());
}

Powered by Google App Engine
This is Rietveld 408576698