cc: Clean up RecordingSource API

cc/layers/picture_layer.h

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CC_LAYERS_PICTURE_LAYER_H_
 #define CC_LAYERS_PICTURE_LAYER_H_
 
 #include "base/macros.h"
 #include "cc/base/invalidation_region.h"
 #include "cc/debug/devtools_instrumentation.h"
 #include "cc/debug/micro_benchmark_controller.h"
 #include "cc/layers/layer.h"
+#include "cc/playback/recording_source.h"
 
 namespace cc {
 
 class ContentLayerClient;
 class RecordingSource;
 class ResourceUpdateQueue;
 
 class CC_EXPORT PictureLayer : public Layer {
  public:
   static scoped_refptr<PictureLayer> Create(ContentLayerClient* client);
 
   void ClearClient();
 
   void SetNearestNeighbor(bool nearest_neighbor);
 
   // Layer interface.
   std::unique_ptr<LayerImpl> CreateLayerImpl(LayerTreeImpl* tree_impl) override;
   void SetLayerTreeHost(LayerTreeHost* host) override;
   void PushPropertiesTo(LayerImpl* layer) override;
   void SetNeedsDisplayRect(const gfx::Rect& layer_rect) override;
   bool Update() override;
   void SetIsMask(bool is_mask) override;
   sk_sp<SkPicture> GetPicture() const override;
   bool IsSuitableForGpuRasterization() const override;
 
   void RunMicroBenchmark(MicroBenchmark* benchmark) override;
 
   ContentLayerClient* client() { return inputs_.client; }
 
-  RecordingSource* GetRecordingSourceForTesting() {
-    return recording_source_.get();
-  }
+  bool UpdateAndExpandInvalidation(
+      Region* invalidation,
+      const gfx::Size& layer_size,
+      RecordingSource::RecordingMode recording_mode,
+      PictureLayerData* pl_data,

[vmpstr, 2016/07/19 23:43:22]

layer_data or picture_layer_data (here and everywhere)

[Menglin, 2016/07/20 21:25:22]

Done. I'm very bad at names...

+      ContentLayerClientData* clc_data,

[vmpstr, 2016/07/19 23:43:22]

client_data (here and everywhere)

[Menglin, 2016/07/20 21:25:22]

Done.

+      InvalidationRegion* invalidation_state) const;
+
+  void SetEmptyBounds();

[vmpstr, 2016/07/19 23:43:22]

This is confusing since cc::Layer has a SetBounds function. It seems like
SetEmptyBounds would be SetBounds(gfx::Size()), but it isn't.

[Menglin, 2016/07/20 21:25:22]

change it to ResetLayerAndClientData

+  void SetSlowdownRasterScaleFactor(int factor);
+  void SetGenerateDiscardableImagesMetadata(bool generate_metadata);
+  void SetBackgroundColorSimple(SkColor background_color);
+  void SetRequiresClear(bool requires_clear);
+  void SetNeedsDisplayRectSimple(const gfx::Rect& layer_rect);
+  gfx::Size GetSize() const;

[vmpstr, 2016/07/19 23:43:22]

Some of these concept become ambiguous/weird when talking about a Layer instead
of a RasterSource... like "Clear" and "GetSize"... I'm not sure what they mean
when applied to a layer. Can you either eliminate some of these calls (as I
commented later), or rename the function and put a comment explaining what it
does?

[Menglin, 2016/07/20 21:25:22]

removed Clear. change GetSize to GetSizeInLayerData

+  const DisplayItemList* GetDisplayItemList();
 
  protected:
   explicit PictureLayer(ContentLayerClient* client);
-  // Allow tests to inject a recording source.
+  // Tests will pass in data instead of a RecordingSource.
   PictureLayer(ContentLayerClient* client,
-               std::unique_ptr<RecordingSource> source);
+               const PictureLayerData& pl_data,
+               const ContentLayerClientData& clc_data);
   ~PictureLayer() override;
 
   bool HasDrawableContent() const override;
   void SetTypeForProtoSerialization(proto::LayerNode* proto) const override;
   void LayerSpecificPropertiesToProto(proto::LayerProperties* proto) override;
   void FromLayerSpecificPropertiesProto(
       const proto::LayerProperties& proto) override;
 
+  void Clear();
+
   bool is_mask() const { return is_mask_; }
 
+  PictureLayerData pl_data_;
+  ContentLayerClientData clc_data_;
+
  private:
   friend class TestSerializationPictureLayer;
 
   void DropRecordingSourceContentIfInvalid();
 
-  std::unique_ptr<RecordingSource> recording_source_;
+  void UpdateInvalidationForNewViewport(const gfx::Rect& old_recorded_viewport,
+                                        const gfx::Rect& new_recorded_viewport,
+                                        Region* invalidation) const;
+
+  void FinishDisplayItemListUpdate(PictureLayerData* pl_data,
+                                   ContentLayerClientData* clc_data) const;
+
+  void DetermineIfSolidColor(PictureLayerData* pl_data,
+                             ContentLayerClientData* clc_data) const;
+
   devtools_instrumentation::
       ScopedLayerObjectTracker instrumentation_object_tracker_;
 
   Region last_updated_invalidation_;
 
   int update_source_frame_number_;
   bool is_mask_;
 
   // Encapsulates all data, callbacks or interfaces received from the embedder.
   struct Inputs {
     ContentLayerClient* client = nullptr;
     bool nearest_neighbor = false;
   };
 
   Inputs inputs_;
 
+  InvalidationRegion invalidation_;
+
   DISALLOW_COPY_AND_ASSIGN(PictureLayer);
 };
 
 }  // namespace cc
 
 #endif  // CC_LAYERS_PICTURE_LAYER_H_