[InputEvent] Fire 'beforeinput'/'input' for 6 text styling actions

[InputEvent] Fire 'beforeinput'/'input' for 6 text styling actions

This CL adds support for the following text styling actions:
1. Bold
2. Italic
3. Underline
4. StrikeThrough
5. Superscript
6. Subscript

'beforeinput' and 'input' events will be fired on context menu actions and hotkeys such as Ctrl+b or Ctrl+i.
(Note: 4,5,6 may not have associated hotkeys currently, but they might be fired from context menu.)

Additionally, 'input' events will also be fired on |execCommand()| for backward compatibility.

BUG=585875
Committed: https://crrev.com/518d3acaa508b210560d95ff5b4d8834801d7e60
Cr-Commit-Position: refs/heads/master@{#405824}

[chongz, 2016-07-13 07:19:58]

Description was changed from

==========
[InputEvent] Support 6 text styling actions

BUG=585875
==========

to

==========
[InputEvent] Fire 'beforeinput'/'input' for 6 text styling actions

This CL adds support for the following 6 text styling actions:
1. Bold
2. Italic
3. Underline
4. StrikeThrough
5. Superscript
6. Subscript

'beforeinput' and 'input' events will be fired on context menu actions and
hotkeys such as Ctrl+b or Ctrl+i.

In additional 'input' events will also be fired on |execCommand()| for backward
compatibility.

BUG=585875
==========

[chongz, 2016-07-13 07:20:20]

Description was changed from

==========
[InputEvent] Fire 'beforeinput'/'input' for 6 text styling actions

This CL adds support for the following 6 text styling actions:
1. Bold
2. Italic
3. Underline
4. StrikeThrough
5. Superscript
6. Subscript

'beforeinput' and 'input' events will be fired on context menu actions and
hotkeys such as Ctrl+b or Ctrl+i.

In additional 'input' events will also be fired on |execCommand()| for backward
compatibility.

BUG=585875
==========

to

==========
[InputEvent] Fire 'beforeinput'/'input' for 6 text styling actions

This CL adds support for the following text styling actions:
1. Bold
2. Italic
3. Underline
4. StrikeThrough
5. Superscript
6. Subscript

'beforeinput' and 'input' events will be fired on context menu actions and
hotkeys such as Ctrl+b or Ctrl+i.

In additional 'input' events will also be fired on |execCommand()| for backward
compatibility.

BUG=585875
==========

[chongz, 2016-07-13 07:22:31]

Description was changed from

==========
[InputEvent] Fire 'beforeinput'/'input' for 6 text styling actions

This CL adds support for the following text styling actions:
1. Bold
2. Italic
3. Underline
4. StrikeThrough
5. Superscript
6. Subscript

'beforeinput' and 'input' events will be fired on context menu actions and
hotkeys such as Ctrl+b or Ctrl+i.

In additional 'input' events will also be fired on |execCommand()| for backward
compatibility.

BUG=585875
==========

to

==========
[InputEvent] Fire 'beforeinput'/'input' for 6 text styling actions

This CL adds support for the following text styling actions:
1. Bold
2. Italic
3. Underline
4. StrikeThrough
5. Superscript
6. Subscript

'beforeinput' and 'input' events will be fired on context menu actions and
hotkeys such as Ctrl+b or Ctrl+i. 
(Note: 4,5,6 may not have associated hotkeys currently, but they might be fired
from context menu.)

Additionally, 'input' events will also be fired on |execCommand()| for backward
compatibility.

BUG=585875
==========

[chongz, 2016-07-13 07:24:39]

chongz@chromium.org changed reviewers:
+ yosin@chromium.org

[chongz, 2016-07-13 07:24:39]

yosin@ PTAL at this text styling InputEvents CL, thanks!

https://codereview.chromium.org/2141133003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp (right):

https://codereview.chromium.org/2141133003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp:206:
frame.editor().applyStyle(style, action);
Not sure why we don't pass |action| before?

https://codereview.chromium.org/2141133003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp:1197: return
executeToggleStyleInList(frame, source, EditActionStrikeThrough,
CSSPropertyWebkitTextDecorationsInEffect, lineThrough);
I'm not sure is this a bug or intentionally?

[yosin_UTC9, 2016-07-13 08:10:42]

lgtm

https://codereview.chromium.org/2141133003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp (right):

https://codereview.chromium.org/2141133003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp:1197: return
executeToggleStyleInList(frame, source, EditActionStrikeThrough,
CSSPropertyWebkitTextDecorationsInEffect, lineThrough);
On 2016/07/13 at 07:24:39, chongz wrote:
> I'm not sure is this a bug or intentionally?

Should be a bug. But, nobody uses |EditActionUnderline|.

[chongz, 2016-07-13 18:06:53]

chongz@chromium.org changed reviewers:
+ ojan@chromium.org

[chongz, 2016-07-13 18:06:54]

ojan@ PTAL, thanks!

[chongz, 2016-07-14 20:53:59]

chongz@chromium.org changed reviewers:
+ bokan@chromium.org
- ojan@chromium.org

[chongz, 2016-07-14 20:54:00]

bokan@ can you take a look at "core/events/InputEvent.h/cpp" please? Thanks!
(The original owner ojan@ seems OOO.)

[bokan, 2016-07-15 14:20:47]

InputEvent.cpp/h lgtm

[chongz, 2016-07-15 15:48:08]

The CQ bit was checked by chongz@chromium.org

[commit-bot: I haz the power, 2016-07-15 15:48:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-15 16:55:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-15 16:55:57]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[chongz, 2016-07-15 18:48:32]

The CQ bit was checked by chongz@chromium.org

[commit-bot: I haz the power, 2016-07-15 18:49:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-15 19:35:47]

Description was changed from

==========
[InputEvent] Fire 'beforeinput'/'input' for 6 text styling actions

This CL adds support for the following text styling actions:
1. Bold
2. Italic
3. Underline
4. StrikeThrough
5. Superscript
6. Subscript

'beforeinput' and 'input' events will be fired on context menu actions and
hotkeys such as Ctrl+b or Ctrl+i. 
(Note: 4,5,6 may not have associated hotkeys currently, but they might be fired
from context menu.)

Additionally, 'input' events will also be fired on |execCommand()| for backward
compatibility.

BUG=585875
==========

to

==========
[InputEvent] Fire 'beforeinput'/'input' for 6 text styling actions

This CL adds support for the following text styling actions:
1. Bold
2. Italic
3. Underline
4. StrikeThrough
5. Superscript
6. Subscript

'beforeinput' and 'input' events will be fired on context menu actions and
hotkeys such as Ctrl+b or Ctrl+i. 
(Note: 4,5,6 may not have associated hotkeys currently, but they might be fired
from context menu.)

Additionally, 'input' events will also be fired on |execCommand()| for backward
compatibility.

BUG=585875
==========

[commit-bot: I haz the power, 2016-07-15 19:35:47]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-15 19:38:28]

Description was changed from

==========
[InputEvent] Fire 'beforeinput'/'input' for 6 text styling actions

This CL adds support for the following text styling actions:
1. Bold
2. Italic
3. Underline
4. StrikeThrough
5. Superscript
6. Subscript

'beforeinput' and 'input' events will be fired on context menu actions and
hotkeys such as Ctrl+b or Ctrl+i. 
(Note: 4,5,6 may not have associated hotkeys currently, but they might be fired
from context menu.)

Additionally, 'input' events will also be fired on |execCommand()| for backward
compatibility.

BUG=585875
==========

to

==========
[InputEvent] Fire 'beforeinput'/'input' for 6 text styling actions

This CL adds support for the following text styling actions:
1. Bold
2. Italic
3. Underline
4. StrikeThrough
5. Superscript
6. Subscript

'beforeinput' and 'input' events will be fired on context menu actions and
hotkeys such as Ctrl+b or Ctrl+i.
(Note: 4,5,6 may not have associated hotkeys currently, but they might be fired
from context menu.)

Additionally, 'input' events will also be fired on |execCommand()| for backward
compatibility.

BUG=585875

Committed: https://crrev.com/518d3acaa508b210560d95ff5b4d8834801d7e60
Cr-Commit-Position: refs/heads/master@{#405824}
==========

[commit-bot: I haz the power, 2016-07-15 19:38:29]

Patchset 1 (id:??) landed as
https://crrev.com/518d3acaa508b210560d95ff5b4d8834801d7e60
Cr-Commit-Position: refs/heads/master@{#405824}