ash/common/wm/overview/window_selector.cc - Issue 2141133002: [ash-md] Animates overview shield in and out

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/common/wm/overview/window_selector.cc

Issue 2141133002: [ash-md] Animates overview shield in and out (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: [ash-md] Completes shield opacity animation after overview closes (avoids crashes with delayed anim… Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ash/common/wm/overview/window_selector.cc

diff --git a/ash/common/wm/overview/window_selector.cc b/ash/common/wm/overview/window_selector.cc

index 3263411e7a0c8570a2d6e6cc649fd9be1bccd8df..e6aac67100be399fe01cd1a03454c6624cee3494 100644

--- a/ash/common/wm/overview/window_selector.cc

+++ b/ash/common/wm/overview/window_selector.cc

@@ -396,6 +396,9 @@ void WindowSelector::Shutdown() {

remaining_items += window_grid->size();

}

+ for (std::unique_ptr<WindowGrid>& window_grid : grid_list_)

+ window_grid->Shutdown();

DCHECK(num_items_ >= remaining_items);

UMA_HISTOGRAM_COUNTS_100("Ash.WindowSelector.OverviewClosedItems",

num_items_ - remaining_items);