Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 214113003: Dispatches mouse movement messages in posted task to improve dragging smoothness (Closed)

Created:
6 years, 9 months ago by varkha
Modified:
6 years, 9 months ago
Reviewers:
sadrul, Elliot Glaysher
CC:
chromium-reviews, tfarina, ben+views_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Dispatches mouse movement messages in posted task to improve dragging smoothness BUG=353869 TEST=Visual, Drag a bookmark over bookmark bar and bookmark bar folders. R=sadrul@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260140

Patch Set 1 #

Total comments: 4

Patch Set 2 : Dispatches mouse movement messages in posted task to improve dragging smoothness (comments) #

Total comments: 12

Patch Set 3 : Dispatches mouse movement messages in posted task to improve dragging smoothness (comments) #

Patch Set 4 : Dispatches mouse movement messages in posted task to improve dragging smoothness (rebase) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -2 lines) Patch
M ui/views/widget/desktop_aura/x11_whole_screen_move_loop.h View 1 3 chunks +6 lines, -0 lines 0 comments Download
M ui/views/widget/desktop_aura/x11_whole_screen_move_loop.cc View 1 2 3 5 chunks +28 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
varkha
https://codereview.chromium.org/214113003/diff/1/ui/views/widget/desktop_aura/x11_whole_screen_move_loop.cc File ui/views/widget/desktop_aura/x11_whole_screen_move_loop.cc (right): https://codereview.chromium.org/214113003/diff/1/ui/views/widget/desktop_aura/x11_whole_screen_move_loop.cc#newcode91 ui/views/widget/desktop_aura/x11_whole_screen_move_loop.cc:91: last_xmotion_ = xev->xmotion; From sadrul@: Don't copy the whole ...
6 years, 9 months ago (2014-03-27 05:41:39 UTC) #1
varkha
sadrul@, Can you please take a look. This is a spin-off from https://codereview.chromium.org/196213004/ that addresses ...
6 years, 9 months ago (2014-03-27 05:46:33 UTC) #2
sadrul
https://codereview.chromium.org/214113003/diff/20001/ui/views/widget/desktop_aura/x11_whole_screen_move_loop.cc File ui/views/widget/desktop_aura/x11_whole_screen_move_loop.cc (right): https://codereview.chromium.org/214113003/diff/20001/ui/views/widget/desktop_aura/x11_whole_screen_move_loop.cc#newcode62 ui/views/widget/desktop_aura/x11_whole_screen_move_loop.cc:62: last_xmotion_.type = NoEventMask; Set this to LASTEvent instead. https://codereview.chromium.org/214113003/diff/20001/ui/views/widget/desktop_aura/x11_whole_screen_move_loop.cc#newcode73 ...
6 years, 9 months ago (2014-03-27 19:25:08 UTC) #3
sadrul
+erg@
6 years, 9 months ago (2014-03-27 19:25:22 UTC) #4
varkha
https://codereview.chromium.org/214113003/diff/20001/ui/views/widget/desktop_aura/x11_whole_screen_move_loop.cc File ui/views/widget/desktop_aura/x11_whole_screen_move_loop.cc (right): https://codereview.chromium.org/214113003/diff/20001/ui/views/widget/desktop_aura/x11_whole_screen_move_loop.cc#newcode62 ui/views/widget/desktop_aura/x11_whole_screen_move_loop.cc:62: last_xmotion_.type = NoEventMask; On 2014/03/27 19:25:09, sadrul wrote: > ...
6 years, 9 months ago (2014-03-27 21:00:54 UTC) #5
sadrul
lgtm
6 years, 9 months ago (2014-03-27 21:02:26 UTC) #6
varkha
The CQ bit was checked by varkha@chromium.org
6 years, 9 months ago (2014-03-27 21:05:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/varkha@chromium.org/214113003/40001
6 years, 9 months ago (2014-03-27 21:14:04 UTC) #8
varkha
6 years, 9 months ago (2014-03-28 15:58:59 UTC) #9
Message was sent while issue was closed.
Committed patchset #4 manually as r260140 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698