Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 2141113002: Revert of [gn] Experiment: Reset -O3 to -O2. (Closed)

Created:
4 years, 5 months ago by Michael Achenbach
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [gn] Experiment: Reset -O3 to -O2. (patchset #1 id:1 of https://codereview.chromium.org/2135313002/ ) Reason for revert: Data collected Original issue's description: > [gn] Experiment: Reset -O3 to -O2. > > Temporary commit to see performance data. Will be reverted > shortly after. > > BUG=chromium:622332 > TBR=vogelheim, jochen > NOTRY=true > > Committed: https://crrev.com/bbb61d8aea732457e1d5a0c9abdd79eacf1622ae > Cr-Commit-Position: refs/heads/master@{#37667} TBR=vogelheim@chromium.org,jochen@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:622332 Committed: https://crrev.com/ce5265016bfb25d0f0eb9e6a4dfb390cd6dbc8ac Cr-Commit-Position: refs/heads/master@{#37690}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M gni/v8.gni View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
Michael Achenbach
Created Revert of [gn] Experiment: Reset -O3 to -O2.
4 years, 5 months ago (2016-07-12 18:18:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2141113002/1
4 years, 5 months ago (2016-07-12 18:18:39 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-12 18:18:50 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-07-12 18:21:50 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ce5265016bfb25d0f0eb9e6a4dfb390cd6dbc8ac
Cr-Commit-Position: refs/heads/master@{#37690}

Powered by Google App Engine
This is Rietveld 408576698