Add redirect method to HttpResponse

tests/standalone/io/http_redirect_test.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 //
 
 import "package:expect/expect.dart";
 import "dart:async";
 import "dart:io";
 
 Future<HttpServer> setupServer() {
@@ skipping 14 matching lines @@
           request.response.statusCode = 404;
           request.response.close();
         });
       }
     });
 
     void addRedirectHandler(int number, int statusCode) {
       addRequestHandler(
          "/$number",
          (HttpRequest request, HttpResponse response) {
-         response.headers.set(HttpHeaders.LOCATION,
-                              "http://127.0.0.1:${server.port}/${number + 1}");
-         response.statusCode = statusCode;
-         response.close();
+           response.redirect("http://127.0.0.1:${server.port}/${number + 1}");
        });
     }
 
     // Setup simple redirect.
     addRequestHandler(
        "/redirect",
        (HttpRequest request, HttpResponse response) {
-         response.headers.set(HttpHeaders.LOCATION,
-                              "http://127.0.0.1:${server.port}/location");
-         response.statusCode = HttpStatus.MOVED_PERMANENTLY;
-         response.close();
+         response.redirect("http://127.0.0.1:${server.port}/location",
+                           HttpStatus.MOVED_PERMANENTLY);
        }
     );
     addRequestHandler(
        "/location",
        (HttpRequest request, HttpResponse response) {
          response.close();
        }
     );
 
     // Setup redirects with relative url.
@@ skipping 16 matching lines @@
     );
 
     addRequestHandler(
        "/some/relativeUrl",
        (HttpRequest request, HttpResponse response) {
          response.close();
        }
     );
 
     addRequestHandler(
+       "/some/relativeToAbsolute",
+       (HttpRequest request, HttpResponse response) {
+         response.redirect("xxx", HttpStatus.SEE_OTHER);
+       }
+    );
+
+    addRequestHandler(
        "/redirectUrl2",
        (HttpRequest request, HttpResponse response) {
          response.headers.set(HttpHeaders.LOCATION, "location");
          response.statusCode = HttpStatus.MOVED_PERMANENTLY;
          response.close();
        }
     );
 
     addRequestHandler(
        "/redirectUrl3",
@@ skipping 353 matching lines @@
     });
   }
   testPath("/redirectUrl");
   testPath("/some/redirectUrl");
   testPath("/redirectUrl2");
   testPath("/redirectUrl3");
   testPath("/redirectUrl4");
   testPath("/redirectUrl5");
 }
 
+void testRedirectRelativeToAbsolute() {
+  setupServer().then((server) {
+    HttpClient client = new HttpClient();
+
+    int redirectCount = 0;
+    handleResponse(HttpClientResponse response) {
+      response.listen(
+          (_) => Expect.fail("Response data not expected"),
+          onDone: () {
+            Expect.equals(HttpStatus.SEE_OTHER, response.statusCode);
+            Expect.equals("http://127.0.0.1:${server.port}/some/xxx",
+                          response.headers["Location"][0]);
+            Expect.isTrue(response.isRedirect);
+            server.close();
+            client.close();
+          });
+    }
+    client.getUrl(
+        Uri.parse("http://127.0.0.1:${server.port}/some/relativeToAbsolute"))
+      .then((HttpClientRequest request) {
+        request.followRedirects = false;
+        return request.close();
+      })
+      .then(handleResponse);
+  });
+}
+
+

[Bill Hesse, 2013/08/02 08:27:36]

One line between functions?

 main() {
   testManualRedirect();
   testManualRedirectWithHeaders();
   testAutoRedirect();
   testAutoRedirectWithHeaders();
   testAutoRedirect301POST();
   testAutoRedirect303POST();
   testAutoRedirectLimit();
   testRedirectLoop();
   testRedirectClosingConnection();
   testRedirectRelativeUrl();
+  testRedirectRelativeToAbsolute();
 }