Add redirect method to HttpResponse

sdk/lib/io/http_impl.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of dart.io;
 
 class _HttpIncoming extends Stream<List<int>> {
   final int _transferLength;
   final Completer _dataCompleter = new Completer();
   Stream<List<int>> _stream;
@@ skipping 690 matching lines @@
     if (_cookies == null) _cookies = new List<Cookie>();
     return _cookies;
   }
 
   String get reasonPhrase => _findReasonPhrase(statusCode);
   void set reasonPhrase(String reasonPhrase) {
     if (_headersWritten) throw new StateError("Header already sent");
     _reasonPhrase = reasonPhrase;
   }
 
+  Future redirect(location, [int status = HttpStatus.MOVED_TEMPORARILY]) {

[Anders Johnsen, 2013/08/02 08:22:03]

Add check for _headersWritten.

[Søren Gjesse, 2013/08/02 09:01:06]

Done.

+    if (location is! String && location is !Uri) throw new ArgumentError();

[Anders Johnsen, 2013/08/02 08:22:03]

"location is not a String or Uri".

Could also be written as:

  if (location is String) uri = ...;
  if (location is! Uri) throw ...;

[Søren Gjesse, 2013/08/02 09:01:06]

Removed and changed type to Uri.

+    if (location is String) location =Uri.parse(location);

[Anders Johnsen, 2013/08/02 08:22:03]

Nit: add space after =.

[Bill Hesse, 2013/08/02 08:27:36]

= Uri.parse

[Søren Gjesse, 2013/08/02 09:01:06]

Line removed.

[Søren Gjesse, 2013/08/02 09:01:06]

Line removed.

+    if (!location.isAbsolute) {
+      Uri base =
+          new Uri(scheme: _httpRequest._httpServer._secure ? "https" : "http",
+                  host: _httpRequest._httpServer._address,

[Anders Johnsen, 2013/08/02 08:22:03]

Host field of request.

[Bill Hesse, 2013/08/02 08:27:36]

_address can be either a String or an InternetAddress, I think.
Uri only takes a String, according to the documentation.

[Søren Gjesse, 2013/08/02 09:01:06]

Line removed.

[Søren Gjesse, 2013/08/02 09:01:06]

Line removed.

+                  port: _httpRequest._httpServer.port,

[Anders Johnsen, 2013/08/02 08:22:03]

Port field of request.

[Søren Gjesse, 2013/08/02 09:01:06]

Line removed.

+                  path: _uri.path);
+      print(base);

[Anders Johnsen, 2013/08/02 08:22:03]

No print ;)

[Bill Hesse, 2013/08/02 08:27:36]

remove print statement.

[Søren Gjesse, 2013/08/02 09:01:06]

Removed.

[Søren Gjesse, 2013/08/02 09:01:06]

Done.

+      location = base.resolveUri(location);
+    }
+    statusCode = status;
+    headers.set("Location", location.toString());
+    return close();
+  }
+
   Future<Socket> detachSocket() {
     if (_headersWritten) throw new StateError("Headers already sent");
     deadline = null;  // Be sure to stop any deadline.
     var future = _httpRequest._httpConnection.detachSocket();
     _writeHeaders(drainRequest: false).then((_) => close());
     // Close connection so the socket is 'free'.
     close();
     done.catchError((_) {
       // Catch any error on done, as they automatically will be
       // propagated to the websocket.
@@ skipping 1161 matching lines @@
   bool get _isActive => _state == _ACTIVE;
   bool get _isIdle => _state == _IDLE;
   bool get _isClosing => _state == _CLOSING;
   bool get _isDetached => _state == _DETACHED;
 }
 
 
 // HTTP server waiting for socket connections.
 class _HttpServer extends Stream<HttpRequest> implements HttpServer {
   String serverHeader = _getHttpVersion();
+  var _address;
+  bool _secure;
 
   static Future<HttpServer> bind(address, int port, int backlog) {
     return ServerSocket.bind(address, port, backlog: backlog).then((socket) {
-      return new _HttpServer._(socket, true);
+      return new _HttpServer._(address, socket, true, false);
     });
   }
 
   static Future<HttpServer> bindSecure(address,
                                        int port,
                                        int backlog,
                                        String certificate_name,
                                        bool requestClientCertificate) {
     return SecureServerSocket.bind(
         address,
         port,
         certificate_name,
         backlog: backlog,
         requestClientCertificate: requestClientCertificate)
         .then((socket) {
-          return new _HttpServer._(socket, true);
+            return new _HttpServer._(address, socket, true, true);
         });
   }
 
-  _HttpServer._(this._serverSocket, this._closeServer) {
+  _HttpServer._(this._address,
+                this._serverSocket,
+                this._closeServer,
+                this._secure) {
     _controller = new StreamController<HttpRequest>(sync: true,
                                                     onCancel: close);
   }
 
   _HttpServer.listenOn(ServerSocket this._serverSocket)
       : _closeServer = false {
     _controller = new StreamController<HttpRequest>(sync: true,
                                                     onCancel: close);
   }
 
@@ skipping 498 matching lines @@
   final Uri location;
 }
 
 String _getHttpVersion() {
   var version = Platform.version;
   // Only include major and minor version numbers.
   int index = version.indexOf('.', version.indexOf('.') + 1);
   version = version.substring(0, index);
   return 'Dart/$version (dart:io)';
 }