Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1383)

Issue 2141093006: In Linux Port, make a dummy HOME directory for running tests. (Closed)

Created:
4 years, 5 months ago by qyearsley
Modified:
4 years, 5 months ago
Reviewers:
Dirk Pranke, mithro
CC:
blink-reviews, chromium-reviews, Dirk Pranke, dgrogan
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

In Linux Port, make a dummy HOME directory for running tests. I haven't really confirmed that this solves the problem because I wasn't able to reproduce it again :-/ Note, there's a related change http://crrev.com/2143123004 which would make it so that the real os.environ isn't used in tests. BUG=612730 Committed: https://crrev.com/803ead9a7c52156198f7c23be623fdd935ea45be Cr-Commit-Position: refs/heads/master@{#405576}

Patch Set 1 #

Patch Set 2 : Remove print statement #

Total comments: 1

Patch Set 3 : Only copy over files that exist #

Patch Set 4 : Fix test and add expand comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -4 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/linux.py View 1 2 3 3 chunks +39 lines, -2 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/linux_unittest.py View 1 2 3 3 chunks +27 lines, -2 lines 0 comments Download

Messages

Total messages: 21 (14 generated)
qyearsley
4 years, 5 months ago (2016-07-13 22:45:49 UTC) #4
qyearsley
In bug 612730, dgrogan says that this CL appears to fix the issue; is there ...
4 years, 5 months ago (2016-07-14 00:00:39 UTC) #7
Dirk Pranke
lgtm
4 years, 5 months ago (2016-07-14 19:19:29 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2141093006/60001
4 years, 5 months ago (2016-07-14 20:03:02 UTC) #17
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 5 months ago (2016-07-14 21:24:39 UTC) #18
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-14 21:24:59 UTC) #19
commit-bot: I haz the power
4 years, 5 months ago (2016-07-14 21:27:59 UTC) #21
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/803ead9a7c52156198f7c23be623fdd935ea45be
Cr-Commit-Position: refs/heads/master@{#405576}

Powered by Google App Engine
This is Rietveld 408576698