Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 2141093003: Revert "Measure whether muted videos that started playing with play() become visible at some point" (Closed)

Created:
4 years, 5 months ago by Dan Beam
Modified:
4 years, 5 months ago
CC:
chromium-reviews, nessy, feature-media-reviews_chromium.org, posciak+watch_chromium.org, blink-reviews-html_chromium.org, gasubic, fs, eric.carlson_apple.com, abarth-chromium, mlamouri+watch-blink_chromium.org, dglazkov+blink, asvitkine+watch_chromium.org, blink-reviews, vcarbune.chromium
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Measure whether muted videos that started playing with play() become visible at some point" This reverts commit 9d961d0a083fe4ebd8c200c31b87d75e4727958b. Seems to be leaking, broke WebKit Leak bots here: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Leak/builds/20963 BUG=627539, 622720 TBR=zqzhang@chromium.org NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true Committed: https://crrev.com/4a8c92c522776d84bfeff56855205fbb5771b785 Cr-Commit-Position: refs/heads/master@{#404836}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -209 lines) Patch
M third_party/WebKit/LayoutTests/media/video-autoplay-experiment-modes-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/core.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
D third_party/WebKit/Source/core/html/AutoplayUmaHelper.h View 1 chunk +0 lines, -67 lines 0 comments Download
D third_party/WebKit/Source/core/html/AutoplayUmaHelper.cpp View 1 chunk +0 lines, -112 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLMediaElement.h View 4 chunks +10 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLMediaElement.cpp View 9 chunks +36 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/html/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +0 lines, -14 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2141093003/1
4 years, 5 months ago (2016-07-12 18:37:33 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 5 months ago (2016-07-12 18:37:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2141093003/1
4 years, 5 months ago (2016-07-12 19:03:53 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/191652)
4 years, 5 months ago (2016-07-12 21:23:32 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2141093003/1
4 years, 5 months ago (2016-07-12 21:29:47 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-12 21:31:12 UTC) #15
commit-bot: I haz the power
4 years, 5 months ago (2016-07-12 21:33:43 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4a8c92c522776d84bfeff56855205fbb5771b785
Cr-Commit-Position: refs/heads/master@{#404836}

Powered by Google App Engine
This is Rietveld 408576698