mojo/public/cpp/utility/lib/run_loop.cc - Issue 2141083003: Add a perf test for async wait and fix a bug in mojo::RunLoop.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/cpp/utility/lib/run_loop.cc

Issue 2141083003: Add a perf test for async wait and fix a bug in mojo::RunLoop. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: oops Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/public/cpp/utility/lib/run_loop.cc

diff --git a/mojo/public/cpp/utility/lib/run_loop.cc b/mojo/public/cpp/utility/lib/run_loop.cc

index 716b1b349868090d5d25e8cb24b9c2983c0e5a33..4ca04da219ff57a95a8b938608dd7695edc991a6 100644

--- a/mojo/public/cpp/utility/lib/run_loop.cc

+++ b/mojo/public/cpp/utility/lib/run_loop.cc

@@ -345,6 +345,9 @@ bool RunLoop::NotifyResults(const std::vector<MojoWaitSetResult>& results) {

auto handler = it->second.handler;

handlers_.erase(it);

+ MojoResult r = WaitSetRemove(wait_set_.get(), id);

+ MOJO_ALLOW_UNUSED_LOCAL(r);

+ assert(r == MOJO_RESULT_OK);

if (result.wait_result == MOJO_RESULT_OK)

handler->OnHandleReady(id);

else