Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(901)

Issue 2141063004: MIPS: Port '[turbofan] Introduce integer multiplication with overflow.' (Closed)

Created:
4 years, 5 months ago by Marija Antic
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: Port '[turbofan] Introduce integer multiplication with overflow.' Port of https://codereview.chromium.org/2101123005/. BUG=

Patch Set 1 #

Patch Set 2 : Add missing files. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+234 lines, -2 lines) Patch
M src/compiler/mips/code-generator-mips.cc View 4 chunks +23 lines, -1 line 0 comments Download
M src/compiler/mips/instruction-codes-mips.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/mips/instruction-selector-mips.cc View 2 chunks +11 lines, -0 lines 0 comments Download
M src/compiler/mips64/code-generator-mips64.cc View 4 chunks +23 lines, -1 line 0 comments Download
M src/compiler/mips64/instruction-codes-mips64.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/mips64/instruction-selector-mips64.cc View 2 chunks +11 lines, -0 lines 0 comments Download
M src/mips/macro-assembler-mips.h View 1 1 chunk +18 lines, -0 lines 0 comments Download
M src/mips/macro-assembler-mips.cc View 1 1 chunk +56 lines, -0 lines 0 comments Download
M src/mips64/macro-assembler-mips64.h View 1 1 chunk +18 lines, -0 lines 0 comments Download
M src/mips64/macro-assembler-mips64.cc View 1 1 chunk +72 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Marija Antic
PTAL. Port of https://codereview.chromium.org/2101123005/
4 years, 5 months ago (2016-07-13 16:26:04 UTC) #2
balazs.kilvady
l-g-t-m
4 years, 5 months ago (2016-07-13 16:42:49 UTC) #3
mvstanton
Hi all, It doesn't compile because of missing MulBranchOvf and MulBranchNoOvf - perhaps there was ...
4 years, 5 months ago (2016-07-13 21:51:09 UTC) #4
Marija Antic
Sorry, I completely missed to upload other folder changes. Added missing files.
4 years, 5 months ago (2016-07-14 07:31:48 UTC) #5
mvstanton
4 years, 5 months ago (2016-07-14 13:52:57 UTC) #7
Message was sent while issue was closed.
Thanks tons!
--Mike

Powered by Google App Engine
This is Rietveld 408576698