Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(969)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2141063003: MD Settings: Allow copying text to clipboard from the About page. (Closed)

Created:
4 years, 5 months ago by dpapad
Modified:
4 years, 5 months ago
Reviewers:
Dan Beam
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Allow copying text to clipboard from the About page. BUG=627578 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/6c8e8a9e0b13fd13fe29e310763a76d0cbc2221a Cr-Commit-Position: refs/heads/master@{#405248}

Patch Set 1 #

Patch Set 2 : Fine tune selection #

Total comments: 2

Patch Set 3 : Nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -3 lines) Patch
M chrome/browser/resources/settings/about_page/about_page.html View 1 2 3 chunks +6 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/about_page/detailed_build_info.html View 1 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
dpapad
Screenshots: http://imgur.com/a/zJgxI
4 years, 5 months ago (2016-07-13 01:20:11 UTC) #3
Dan Beam
lgtm w/nit https://codereview.chromium.org/2141063003/diff/20001/chrome/browser/resources/settings/about_page/about_page.html File chrome/browser/resources/settings/about_page/about_page.html (right): https://codereview.chromium.org/2141063003/diff/20001/chrome/browser/resources/settings/about_page/about_page.html#newcode27 chrome/browser/resources/settings/about_page/about_page.html:27: div.copyable { nit: div doesn't help in ...
4 years, 5 months ago (2016-07-13 01:49:00 UTC) #4
dpapad
https://codereview.chromium.org/2141063003/diff/20001/chrome/browser/resources/settings/about_page/about_page.html File chrome/browser/resources/settings/about_page/about_page.html (right): https://codereview.chromium.org/2141063003/diff/20001/chrome/browser/resources/settings/about_page/about_page.html#newcode27 chrome/browser/resources/settings/about_page/about_page.html:27: div.copyable { On 2016/07/13 at 01:49:00, Dan Beam wrote: ...
4 years, 5 months ago (2016-07-13 17:40:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2141063003/40001
4 years, 5 months ago (2016-07-13 17:41:30 UTC) #8
commit-bot: I haz the power
Your CL relies on deprecated CQ feature(s): * Specifying master names without "master." prefix is ...
4 years, 5 months ago (2016-07-13 19:33:46 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-13 20:00:44 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 20:02:27 UTC) #12
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/6c8e8a9e0b13fd13fe29e310763a76d0cbc2221a
Cr-Commit-Position: refs/heads/master@{#405248}

Powered by Google App Engine
This is Rietveld 408576698