Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(904)

Issue 2141013004: Mac a11y: Add Help, TopLevelUIElement, and Window accessibility attributes. (Closed)

Created:
4 years, 5 months ago by Patti Lor
Modified:
4 years, 4 months ago
Reviewers:
tapted, dmazzoni
CC:
aboxhall+watch_chromium.org, chrome-apps-syd-reviews_chromium.org, chromium-reviews, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, je_julie, nektar+watch_chromium.org, tfarina, yuzo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mac a11y: Add Help, TopLevelUIElement, and Window accessibility attributes. Add the accessibilityHelp (derived from the tooltip text), accessibilityTopLevelUIElement, and accessibilityWindow accessibility attributes for Mac, with tests. BUG=610591 Committed: https://crrev.com/37f9fc7c83fd0386d554fb93213287b698b037c0 Cr-Commit-Position: refs/heads/master@{#408029}

Patch Set 1 #

Patch Set 2 : Implement for TestAXNodeWrapper. #

Patch Set 3 : Implement for AuraLinuxApplication. #

Patch Set 4 : Test views without tooltips set. #

Total comments: 11

Patch Set 5 : Fix WindowAndTopLevelUIElementAttributes test view size. #

Patch Set 6 : Add null check for NVA::GetTopLevelWidget(). #

Total comments: 2

Patch Set 7 : Use AX_ATTR_DESCRIPTION instead of adding AX_ATTR_HELP_TEXT, remove use of AX_ATTR_DESCRIPTION from… #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -10 lines) Patch
M ui/accessibility/ax_view_state.h View 1 2 3 4 5 6 1 chunk +3 lines, -0 lines 0 comments Download
M ui/accessibility/platform/ax_platform_node_delegate.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/accessibility/platform/ax_platform_node_mac.mm View 1 2 3 4 5 6 3 chunks +16 lines, -4 lines 0 comments Download
M ui/accessibility/platform/test_ax_node_wrapper.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M ui/accessibility/platform/test_ax_node_wrapper.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M ui/views/accessibility/native_view_accessibility.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/accessibility/native_view_accessibility.cc View 1 2 3 4 5 6 3 chunks +13 lines, -0 lines 0 comments Download
M ui/views/accessibility/native_view_accessibility_auralinux.cc View 1 2 2 chunks +4 lines, -6 lines 0 comments Download
M ui/views/widget/native_widget_mac_accessibility_unittest.mm View 1 2 3 4 2 chunks +28 lines, -0 lines 0 comments Download

Messages

Total messages: 32 (22 generated)
Patti Lor
Hi Trent, PTAL.
4 years, 5 months ago (2016-07-15 03:10:56 UTC) #8
tapted
https://codereview.chromium.org/2141013004/diff/60001/ui/views/accessibility/native_view_accessibility.cc File ui/views/accessibility/native_view_accessibility.cc (right): https://codereview.chromium.org/2141013004/diff/60001/ui/views/accessibility/native_view_accessibility.cc#newcode70 ui/views/accessibility/native_view_accessibility.cc:70: if (view_->GetTooltipText(gfx::Point(), &state.help_text)) passing gfx::Point() might not work for ...
4 years, 5 months ago (2016-07-18 03:38:49 UTC) #9
Patti Lor
Thanks Trent, PTAL. https://codereview.chromium.org/2141013004/diff/60001/ui/views/accessibility/native_view_accessibility.cc File ui/views/accessibility/native_view_accessibility.cc (right): https://codereview.chromium.org/2141013004/diff/60001/ui/views/accessibility/native_view_accessibility.cc#newcode70 ui/views/accessibility/native_view_accessibility.cc:70: if (view_->GetTooltipText(gfx::Point(), &state.help_text)) On 2016/07/18 03:38:48, ...
4 years, 5 months ago (2016-07-19 01:14:10 UTC) #10
tapted
lgtm with a null check https://codereview.chromium.org/2141013004/diff/60001/ui/views/accessibility/native_view_accessibility.cc File ui/views/accessibility/native_view_accessibility.cc (right): https://codereview.chromium.org/2141013004/diff/60001/ui/views/accessibility/native_view_accessibility.cc#newcode70 ui/views/accessibility/native_view_accessibility.cc:70: if (view_->GetTooltipText(gfx::Point(), &state.help_text)) On ...
4 years, 5 months ago (2016-07-19 03:22:51 UTC) #13
Patti Lor
+dmazzoni@ for ui/accessibility/* and ui/views/accessibility/* PTAL, thank you! https://codereview.chromium.org/2141013004/diff/60001/ui/views/accessibility/native_view_accessibility.cc File ui/views/accessibility/native_view_accessibility.cc (right): https://codereview.chromium.org/2141013004/diff/60001/ui/views/accessibility/native_view_accessibility.cc#newcode70 ui/views/accessibility/native_view_accessibility.cc:70: if ...
4 years, 5 months ago (2016-07-19 05:29:24 UTC) #20
dmazzoni
lgtm lgtm but just use AX_ATTR_DESCRIPTION for secondary accessible text like tooltip text that maps ...
4 years, 4 months ago (2016-07-26 22:26:56 UTC) #21
Patti Lor
https://codereview.chromium.org/2141013004/diff/100001/ui/accessibility/ax_enums.idl File ui/accessibility/ax_enums.idl (right): https://codereview.chromium.org/2141013004/diff/100001/ui/accessibility/ax_enums.idl#newcode245 ui/accessibility/ax_enums.idl:245: description, On 2016/07/26 22:26:56, dmazzoni wrote: > It's not ...
4 years, 4 months ago (2016-07-27 02:59:00 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2141013004/120001
4 years, 4 months ago (2016-07-27 02:59:26 UTC) #29
commit-bot: I haz the power
Committed patchset #7 (id:120001)
4 years, 4 months ago (2016-07-27 03:02:44 UTC) #30
commit-bot: I haz the power
4 years, 4 months ago (2016-07-27 03:04:33 UTC) #32
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/37f9fc7c83fd0386d554fb93213287b698b037c0
Cr-Commit-Position: refs/heads/master@{#408029}

Powered by Google App Engine
This is Rietveld 408576698