[turbofan] Speed up structural graph verification.

[turbofan] Speed up structural graph verification.

This removes the checking for use-def and def-use chain links from the
graph verification. Presence of such links can only be violated by a bug
in the actual {Node} implementation itself. That container class is also
covered by unit tests.

The verification in question was useful in the early days when the graph
implementation itself was prone to bugs. By now it has stabilized and
spending O(n^2) time during graph verification is too wasteful to still
be considered a reasonable trade-off.

R=jarin@chromium.org
TEST=unittests/NodeTest.*

Committed: https://crrev.com/f3ca2142221a1f29be4c43b1fd44840df1318df2
Cr-Commit-Position: refs/heads/master@{#37670}

[Michael Starzinger, 2016-07-12 09:09:24]

Description was changed from

==========
[turbofan] Speed up structural graph verification.

This removes the checking for use-def and def-use chain links from the
graph verification. Presence of such links can only be violated by a bug
in the actual {Node} implementation itself. That container class is also
covered by unit tests.

The verification in question was useful in the early days when the graph
implementation itself was prone to bugs. By now it has stabilized and
spending O(n^2) time during graph verification is too wasteful to still
be considered a reasonable tradeoff.

R=jarin@chromium.org
TEST=unittests/NodeTest.*
==========

to

==========
[turbofan] Speed up structural graph verification.

This removes the checking for use-def and def-use chain links from the
graph verification. Presence of such links can only be violated by a bug
in the actual {Node} implementation itself. That container class is also
covered by unit tests.

The verification in question was useful in the early days when the graph
implementation itself was prone to bugs. By now it has stabilized and
spending O(n^2) time during graph verification is too wasteful to still
be considered a reasonable trade-off.

R=jarin@chromium.org
TEST=unittests/NodeTest.*
==========

[Michael Starzinger, 2016-07-12 09:09:45]

mstarzinger@chromium.org changed reviewers:
+ jkummerow@chromium.org

[Michael Starzinger, 2016-07-12 09:09:45]

Jaro: PTAL.
Jakob: FYI.

[titzer, 2016-07-12 09:18:49]

On 2016/07/12 09:09:45, Michael Starzinger wrote:
> Jaro: PTAL.
> Jakob: FYI.

lgtm

[Michael Starzinger, 2016-07-12 09:28:04]

The CQ bit was checked by mstarzinger@chromium.org

[commit-bot: I haz the power, 2016-07-12 09:28:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-12 09:30:53]

Description was changed from

==========
[turbofan] Speed up structural graph verification.

This removes the checking for use-def and def-use chain links from the
graph verification. Presence of such links can only be violated by a bug
in the actual {Node} implementation itself. That container class is also
covered by unit tests.

The verification in question was useful in the early days when the graph
implementation itself was prone to bugs. By now it has stabilized and
spending O(n^2) time during graph verification is too wasteful to still
be considered a reasonable trade-off.

R=jarin@chromium.org
TEST=unittests/NodeTest.*
==========

to

==========
[turbofan] Speed up structural graph verification.

This removes the checking for use-def and def-use chain links from the
graph verification. Presence of such links can only be violated by a bug
in the actual {Node} implementation itself. That container class is also
covered by unit tests.

The verification in question was useful in the early days when the graph
implementation itself was prone to bugs. By now it has stabilized and
spending O(n^2) time during graph verification is too wasteful to still
be considered a reasonable trade-off.

R=jarin@chromium.org
TEST=unittests/NodeTest.*
==========

[commit-bot: I haz the power, 2016-07-12 09:30:54]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-12 09:31:17]

Description was changed from

==========
[turbofan] Speed up structural graph verification.

This removes the checking for use-def and def-use chain links from the
graph verification. Presence of such links can only be violated by a bug
in the actual {Node} implementation itself. That container class is also
covered by unit tests.

The verification in question was useful in the early days when the graph
implementation itself was prone to bugs. By now it has stabilized and
spending O(n^2) time during graph verification is too wasteful to still
be considered a reasonable trade-off.

R=jarin@chromium.org
TEST=unittests/NodeTest.*
==========

to

==========
[turbofan] Speed up structural graph verification.

This removes the checking for use-def and def-use chain links from the
graph verification. Presence of such links can only be violated by a bug
in the actual {Node} implementation itself. That container class is also
covered by unit tests.

The verification in question was useful in the early days when the graph
implementation itself was prone to bugs. By now it has stabilized and
spending O(n^2) time during graph verification is too wasteful to still
be considered a reasonable trade-off.

R=jarin@chromium.org
TEST=unittests/NodeTest.*

Committed: https://crrev.com/f3ca2142221a1f29be4c43b1fd44840df1318df2
Cr-Commit-Position: refs/heads/master@{#37670}
==========

[commit-bot: I haz the power, 2016-07-12 09:31:18]

Patchset 1 (id:??) landed as
https://crrev.com/f3ca2142221a1f29be4c43b1fd44840df1318df2
Cr-Commit-Position: refs/heads/master@{#37670}

[Jakob Kummerow, 2016-07-12 09:33:45]

Cool, thanks!