chrome/browser/ui/views/translate/translate_bubble_view.cc - Issue 2140963002: Added default implementations of GetAcceleratorForCommandId.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/translate/translate_bubble_view.cc

Issue 2140963002: Added default implementations of GetAcceleratorForCommandId. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@acceleratorprovider-const

Patch Set: Rebase. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/translate/translate_bubble_view.h ('k') | chrome/browser/ui/website_settings/permission_menu_model.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/translate/translate_bubble_view.cc

diff --git a/chrome/browser/ui/views/translate/translate_bubble_view.cc b/chrome/browser/ui/views/translate/translate_bubble_view.cc

index 29f24e21259ebca4a834580f9eed21f49e7572b7..17d921c273bd176aa21fcd2c38d5359b956d5c94 100644

--- a/chrome/browser/ui/views/translate/translate_bubble_view.cc

+++ b/chrome/browser/ui/views/translate/translate_bubble_view.cc

@@ -316,12 +316,6 @@ bool TranslateBubbleView::IsCommandIdEnabled(int command_id) const {

return true;

}

-bool TranslateBubbleView::GetAcceleratorForCommandId(

- int command_id,

- ui::Accelerator* accelerator) const {

- return false;

void TranslateBubbleView::ExecuteCommand(int command_id, int event_flags) {

model_->DeclineTranslation();

switch (command_id) {