chrome/browser/renderer_context_menu/open_with_menu_factory_ash.cc - Issue 2140963002: Added default implementations of GetAcceleratorForCommandId.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/renderer_context_menu/open_with_menu_factory_ash.cc

Issue 2140963002: Added default implementations of GetAcceleratorForCommandId. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@acceleratorprovider-const

Patch Set: Rebase. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/renderer_context_menu/open_with_menu_factory_ash.h ('k') | chrome/browser/renderer_context_menu/render_view_context_menu_test_util.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/renderer_context_menu/open_with_menu_factory_ash.cc

diff --git a/chrome/browser/renderer_context_menu/open_with_menu_factory_ash.cc b/chrome/browser/renderer_context_menu/open_with_menu_factory_ash.cc

index c4494b2e78367b13f95c8bb1bc7a89c909d17139..6b815372f7489a47b10dd8a2cbed18a02c144ee6 100644

--- a/chrome/browser/renderer_context_menu/open_with_menu_factory_ash.cc

+++ b/chrome/browser/renderer_context_menu/open_with_menu_factory_ash.cc

@@ -35,12 +35,6 @@ bool OpenWithMenuObserver::SubMenuDelegate::IsCommandIdEnabled(

return true;

}

-bool OpenWithMenuObserver::SubMenuDelegate::GetAcceleratorForCommandId(

- int command_id,

- ui::Accelerator* accelerator) const {

- return false;

void OpenWithMenuObserver::SubMenuDelegate::ExecuteCommand(int command_id,

int event_flags) {

parent_->ExecuteCommand(command_id);