Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issue 214093002: Replace deprecated webkitCreateShadowRoot with createShadowRoot. (Closed)

Created:
6 years, 9 months ago by hayato
Modified:
6 years, 9 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, stgao, extensions-reviews_chromium.org
Visibility:
Public.

Description

Replace deprecated webkitCreateShadowRoot with createShadowRoot. This is a pre-requirement to remove webkitCreateShadowRoot in blink. The patch on the blink side is here: https://codereview.chromium.org/208503004/. BUG=336121 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260197

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M chrome/renderer/resources/extensions/ad_view.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/resources/extensions/inject_app_titlebar.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/resources/extensions/web_view.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/resources/extensions/window_controls.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/chromedriver/js/call_function_test.html View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 28 (0 generated)
hayato
PTAL.
6 years, 9 months ago (2014-03-27 01:18:38 UTC) #1
esprehn
lgtm, but I don't have the power to really lgtm out there. You need a ...
6 years, 9 months ago (2014-03-27 01:35:46 UTC) #2
hayato
Thank you for the review. Adding some reviewers in chrome/renderer/resources/extensions/OWNERS for another LGTM for files ...
6 years, 9 months ago (2014-03-27 08:55:29 UTC) #3
lazyboy
lgtm web_view.js, ad_view.js LGTM
6 years, 9 months ago (2014-03-27 18:35:54 UTC) #4
dglazkov
The CQ bit was checked by dglazkov@chromium.org
6 years, 9 months ago (2014-03-27 19:02:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hayato@chromium.org/214093002/1
6 years, 9 months ago (2014-03-27 19:05:42 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-27 19:33:42 UTC) #7
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=58034
6 years, 9 months ago (2014-03-27 19:33:42 UTC) #8
esprehn
The CQ bit was checked by esprehn@chromium.org
6 years, 9 months ago (2014-03-27 20:01:35 UTC) #9
esprehn
The CQ bit was unchecked by esprehn@chromium.org
6 years, 9 months ago (2014-03-27 20:01:51 UTC) #10
esprehn
Still not enough owners? ** Presubmit ERRORS ** Missing LGTM from an OWNER for these ...
6 years, 9 months ago (2014-03-27 20:02:03 UTC) #11
stgao
lgtm for chrome/test/chromedriver/js/call_function_test.html
6 years, 9 months ago (2014-03-27 20:03:04 UTC) #12
hayato
The CQ bit was checked by hayato@chromium.org
6 years, 9 months ago (2014-03-28 03:22:51 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hayato@chromium.org/214093002/1
6 years, 9 months ago (2014-03-28 03:23:28 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-28 04:11:10 UTC) #15
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=58191
6 years, 9 months ago (2014-03-28 04:11:11 UTC) #16
hayato
Ops. We still need per-file lgtm for - chrome/renderer/resources/extensions/inject_app_titlebar.js - chrome/renderer/resources/extensions/window_controls.js Adding more reviewers. +koz, ...
6 years, 9 months ago (2014-03-28 05:08:26 UTC) #17
koz (OOO until 15th September)
lgtm
6 years, 9 months ago (2014-03-28 05:23:14 UTC) #18
hayato
The CQ bit was checked by hayato@chromium.org
6 years, 9 months ago (2014-03-28 05:24:58 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hayato@chromium.org/214093002/1
6 years, 9 months ago (2014-03-28 05:25:36 UTC) #20
hayato
The CQ bit was unchecked by hayato@chromium.org
6 years, 9 months ago (2014-03-28 06:24:45 UTC) #21
hayato
The CQ bit was checked by hayato@chromium.org
6 years, 9 months ago (2014-03-28 06:27:54 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hayato@chromium.org/214093002/1
6 years, 9 months ago (2014-03-28 06:28:28 UTC) #23
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-28 08:35:57 UTC) #24
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) url_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_simulator&number=136952
6 years, 9 months ago (2014-03-28 08:35:57 UTC) #25
dglazkov
The CQ bit was checked by dglazkov@chromium.org
6 years, 9 months ago (2014-03-28 15:36:41 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hayato@chromium.org/214093002/1
6 years, 9 months ago (2014-03-28 15:37:40 UTC) #27
commit-bot: I haz the power
6 years, 9 months ago (2014-03-28 18:10:01 UTC) #28
Message was sent while issue was closed.
Change committed as 260197

Powered by Google App Engine
This is Rietveld 408576698