Issue 2140923003: Remove itself from the widget observers in destructor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2140923003: Remove itself from the widget observers in destructor (Closed)

Created:
4 years, 5 months ago by yoshiki

Modified:
4 years, 5 months ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2743

Target Ref:
refs/pending/branch-heads/2743

Project:
chromium

Visibility:
Public.

Remove itself from the widget observers in destructor This patch may fix the use-after-free reported in crbug.com/612050. BUG=612050 TEST=msan passes Review-Url: https://codereview.chromium.org/2031763003 Cr-Commit-Position: refs/heads/master@{#402408} (cherry picked from commit 58f821b32a3b99bf15855225dff13d77f10d7484) Committed: https://chromium.googlesource.com/chromium/src/+/48a749e6902eab2284b7b670e1e053d7338fa8f0

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -1 line)			Patch
	M	ui/message_center/views/message_center_bubble.cc	View		2 chunks	+6 lines, -1 line	0 comments	Download

Total messages: 2 (1 generated)

yoshiki

4 years, 5 months ago (2016-07-12 03:55:14 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
48a749e6902eab2284b7b670e1e053d7338fa8f0.