Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 2140863002: Use hintgasp font when testing rendering. (Closed)

Created:
4 years, 5 months ago by bungeman-skia
Modified:
4 years, 5 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Use hintgasp font when testing rendering. The hintgasp font was added specifically for the typefacerendering gm. However, this gm didn't actually use the font, so now use it. In addition this adds embedded bitmap strikes to the hintgasp font and the gm is updated to test these as well. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2140863002 NOTREECHECKS=true Test only change, does not affect users. Committed: https://skia.googlesource.com/skia/+/5dba301e916448bbb17bfe8e70dc367f32eb7159

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M gm/typeface.cpp View 3 chunks +6 lines, -2 lines 0 comments Download
M resources/fonts/hintgasp.ttf View Binary file 0 comments Download

Messages

Total messages: 17 (12 generated)
bungeman-skia
Forgot to actually hook up the font. Added embedded bitmaps to the font because it ...
4 years, 5 months ago (2016-07-11 22:32:33 UTC) #6
mtklein
lgtm
4 years, 5 months ago (2016-07-11 22:44:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2140863002/1
4 years, 5 months ago (2016-07-12 13:19:56 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2140863002/1
4 years, 5 months ago (2016-07-12 13:54:34 UTC) #15
commit-bot: I haz the power
4 years, 5 months ago (2016-07-12 13:55:31 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/5dba301e916448bbb17bfe8e70dc367f32eb7159

Powered by Google App Engine
This is Rietveld 408576698