Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 2140853003: Fix keyboard commands on bookmarks page. (Closed)

Created:
4 years, 5 months ago by dtapuska
Modified:
4 years, 5 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, asanka, tfarina, michaelpg+watch-md-ui_chromium.org, noyau+watch_chromium.org, arv+watch_chromium.org, dbeam+watch-downloads_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix keyboard commands on bookmarks page. Appears I missed a set of hotkey commands on the bookmark page when removing keyIdentifier and supporting KeyboardEvent.key. I've verified U+007F is no longer used via a grep. Remove some dead code too. BUG=627364 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/7185ed0ef16da5c97142491d4c6d07df5c4e250b Cr-Commit-Position: refs/heads/master@{#404902}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Undo cripser.js change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -11 lines) Patch
M chrome/browser/resources/bookmark_manager/js/main.js View 1 chunk +11 lines, -11 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
dtapuska
4 years, 5 months ago (2016-07-12 13:12:45 UTC) #3
Dan Beam
https://codereview.chromium.org/2140853003/diff/1/chrome/browser/resources/md_downloads/crisper.js File chrome/browser/resources/md_downloads/crisper.js (left): https://codereview.chromium.org/2140853003/diff/1/chrome/browser/resources/md_downloads/crisper.js#oldcode1702 chrome/browser/resources/md_downloads/crisper.js:1702: * Chrome uses an older version of DOM Level ...
4 years, 5 months ago (2016-07-12 19:59:30 UTC) #4
dtapuska
On 2016/07/12 19:59:30, Dan Beam wrote: > https://codereview.chromium.org/2140853003/diff/1/chrome/browser/resources/md_downloads/crisper.js > File chrome/browser/resources/md_downloads/crisper.js (left): > > https://codereview.chromium.org/2140853003/diff/1/chrome/browser/resources/md_downloads/crisper.js#oldcode1702 ...
4 years, 5 months ago (2016-07-12 20:04:05 UTC) #5
Dan Beam
yeah, just revert that. it's auto pulled + generated from polymer code :/
4 years, 5 months ago (2016-07-12 21:03:08 UTC) #6
dtapuska
On 2016/07/12 21:03:08, Dan Beam wrote: > yeah, just revert that. it's auto pulled + ...
4 years, 5 months ago (2016-07-12 21:17:08 UTC) #7
Dan Beam
lgtm
4 years, 5 months ago (2016-07-12 22:33:56 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2140853003/20001
4 years, 5 months ago (2016-07-12 22:50:47 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-13 02:19:28 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 02:21:23 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7185ed0ef16da5c97142491d4c6d07df5c4e250b
Cr-Commit-Position: refs/heads/master@{#404902}

Powered by Google App Engine
This is Rietveld 408576698