Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 2140843002: Allow arc app to lock screen orientation in TouchView/Tablet mode (Closed)

Created:
4 years, 5 months ago by oshima
Modified:
4 years, 5 months ago
Reviewers:
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, tapted, qsr+mojo_chromium.org, sadrul, yusukes+watch_chromium.org, viettrungluu+watch_chromium.org, mlamouri+watch-screen-orientation_chromium.org, tfarina, hidehiko+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, lhchavez+watch_chromium.org, kalyank, darin (slow to review), ben+mojo_chromium.org, Matt Giuca
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

Allow arc app to lock screen orientation in TouchView/Tablet mode mojo change: * Added orientation lock parameter to AppInfo * Added OnTaskOrientationLockRequested method on AppHost c++ change: * Apply orientation lock to arc windows upon Tablet mode entry * Unset lock and set the rotation back upon Tablet mode exit. * Apply the rotation lock when a task requested. This is kept only on memory and does not persist. BUG=626445 ,b/28341028 TEST=ChromeLauncherControllerImplTest.ArcOrientatinoLock Review-Url: https://codereview.chromium.org/2112013002 Cr-Commit-Position: refs/heads/master@{#404244} (cherry picked from commit 342f3485150be7e10404671e811d9c881f8b62ea) Committed: https://chromium.googlesource.com/chromium/src/+/41c090842fe6ec0a457cb92998336f2884b6e5c2

Patch Set 1 #

Patch Set 2 : Mark POWER key as system key so that it won't be passed to regular apps. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+225 lines, -98 lines) Patch
M ash/accelerators/accelerator_delegate.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M ash/accelerators/accelerator_delegate.cc View 1 1 chunk +30 lines, -4 lines 0 comments Download
M chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.cc View 1 4 chunks +30 lines, -0 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc View 1 5 chunks +158 lines, -52 lines 0 comments Download
M components/arc/common/app.mojom View 1 4 chunks +4 lines, -3 lines 0 comments Download
M ui/wm/core/accelerator_delegate.h View 1 1 chunk +1 line, -8 lines 0 comments Download
M ui/wm/core/accelerator_filter.cc View 1 2 chunks +1 line, -29 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
oshima
4 years, 5 months ago (2016-07-11 22:08:01 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
41c090842fe6ec0a457cb92998336f2884b6e5c2.

Powered by Google App Engine
This is Rietveld 408576698