ui/gfx/color_space_win.cc - Issue 2140803002: Color: Don't duplicate ICC profile data

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/gfx/color_space_win.cc

Issue 2140803002: Color: Don't duplicate ICC profile data (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Incorporate review feedback Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/gfx/color_space_win.cc

diff --git a/ui/gfx/color_space_win.cc b/ui/gfx/color_space_win.cc

index e9db49fc0d5731bd4b46828a84eb8cc230172585..9446c4eeab4cc9df8b065aa48ae0a3832ad8d1b8 100644

--- a/ui/gfx/color_space_win.cc

+++ b/ui/gfx/color_space_win.cc

@@ -59,9 +59,10 @@ bool ColorSpace::CachedProfilesNeedUpdate() {

void ColorSpace::UpdateCachedProfilesOnBackgroundThread() {

std::vector<char> icc_profile;

ReadBestMonitorICCProfile(&icc_profile);

+ gfx::ColorSpace color_space = FromICCProfile(icc_profile);

base::AutoLock lock(g_best_monitor_color_space_lock.Get());

- g_best_monitor_color_space.Get().icc_profile_ = icc_profile;

+ g_best_monitor_color_space.Get() = color_space;

g_has_initialized_best_monitor_color_space = true;

}