Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(459)

Unified Diff: content/browser/renderer_host/p2p/socket_host_tcp_server.cc

Issue 2140693002: Support port range for IPC P2P UDP sockets. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix compile issues Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/p2p/socket_host_tcp_server.cc
diff --git a/content/browser/renderer_host/p2p/socket_host_tcp_server.cc b/content/browser/renderer_host/p2p/socket_host_tcp_server.cc
index a2c031e769830ac990c307744b3ca49d57c802d1..a4af785b3300a6d5a942ea4740125a375610a2d6 100644
--- a/content/browser/renderer_host/p2p/socket_host_tcp_server.cc
+++ b/content/browser/renderer_host/p2p/socket_host_tcp_server.cc
@@ -39,7 +39,10 @@ P2PSocketHostTcpServer::~P2PSocketHostTcpServer() {
}
}
+// TODO(guidou): Add support for port range.
tommi (sloooow) - chröme 2016/07/11 17:54:59 I guess this means a separate policy then?
Guido Urdaneta 2016/07/12 10:15:00 In the meantime the only call site is https://cs.c
tommi (sloooow) - chröme 2016/07/12 10:21:46 I think it's OK to not address it in this CL but a
bool P2PSocketHostTcpServer::Init(const net::IPEndPoint& local_address,
+ uint16_t min_port,
+ uint16_t max_port,
const P2PHostAndIPEndPoint& remote_address) {
DCHECK_EQ(state_, STATE_UNINITIALIZED);

Powered by Google App Engine
This is Rietveld 408576698