Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 2140673004: Generalize the first argument in an assert to be an expression (issue 26865) (Closed)

Created:
4 years, 5 months ago by Brian Wilkerson
Modified:
4 years, 5 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Generalize the first argument in an assert to be an expression (issue 26865) R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/afd21330f77c4442082fa4ba1f9bdf9dce6f7cd6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -59 lines) Patch
M pkg/analyzer/lib/src/generated/error.dart View 1 chunk +0 lines, -4 lines 0 comments Download
M pkg/analyzer/lib/src/generated/parser.dart View 2 chunks +1 line, -30 lines 0 comments Download
M pkg/analyzer/test/generated/parser_test.dart View 1 chunk +0 lines, -20 lines 0 comments Download
M tests/corelib/corelib.status View 1 chunk +0 lines, -2 lines 0 comments Download
M tests/language/language_analyzer2.status View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Brian Wilkerson
4 years, 5 months ago (2016-07-12 15:24:21 UTC) #3
scheglov
LGTM
4 years, 5 months ago (2016-07-12 15:36:18 UTC) #4
Brian Wilkerson
4 years, 5 months ago (2016-07-12 18:02:43 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
afd21330f77c4442082fa4ba1f9bdf9dce6f7cd6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698