Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 2140673003: Fix race in EmbeddedApplicationRunner::ShutDown (Closed)

Created:
4 years, 5 months ago by Ken Rockot(use gerrit already)
Modified:
4 years, 5 months ago
Reviewers:
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), darin-cc_chromium.org, jam, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix race in EmbeddedApplicationRunner::ShutDown Joins the application thread before resetting the stored TaskRunner reference. Avoids a nullptr dereference if ShutDown is called immediately after BindServiceRequest but before the posted task has run. BUG=626299 TBR=ben@chromium.org Committed: https://crrev.com/5265f8ef11e3205bdbbd0178f8c739e6e39973b7 Cr-Commit-Position: refs/heads/master@{#404713}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/common/mojo/embedded_application_runner.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2140673003/1
4 years, 5 months ago (2016-07-11 17:56:51 UTC) #3
Ken Rockot(use gerrit already)
TBRing since: change is trivial, ben is the right reviewer, fixes a crash, and ben ...
4 years, 5 months ago (2016-07-11 17:57:50 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-11 19:57:57 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-07-11 20:02:52 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5265f8ef11e3205bdbbd0178f8c739e6e39973b7
Cr-Commit-Position: refs/heads/master@{#404713}

Powered by Google App Engine
This is Rietveld 408576698