Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 2140663002: Update documents/scripts for SampleApp removal (Closed)

Created:
4 years, 5 months ago by liyuqian
Modified:
4 years, 5 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Update documents/scripts for SampleApp removal BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2140663002 DOCS_PREVIEW= https://skia.org/?cl=2140663002 Committed: https://skia.googlesource.com/skia/+/e7d15fe870e8d6b0d4b072fc02a2a1c079743485

Patch Set 1 #

Patch Set 2 : Fix install #

Total comments: 2

Patch Set 3 : Resources #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -76 lines) Patch
M platform_tools/android/bin/android_gdb_app View 1 chunk +4 lines, -17 lines 0 comments Download
M platform_tools/android/bin/android_install_app View 1 4 chunks +2 lines, -20 lines 0 comments Download
M platform_tools/android/bin/android_launch_app View 2 chunks +2 lines, -16 lines 0 comments Download
M site/user/quick/android.md View 1 2 4 chunks +23 lines, -23 lines 2 comments Download

Messages

Total messages: 14 (5 generated)
liyuqian
Since we've removed SampleApp on Android, let's update the document and scripts. Note that there's ...
4 years, 5 months ago (2016-07-11 17:08:41 UTC) #4
djsollen
https://codereview.chromium.org/2140663002/diff/20001/site/user/quick/android.md File site/user/quick/android.md (left): https://codereview.chromium.org/2140663002/diff/20001/site/user/quick/android.md#oldcode159 site/user/quick/android.md:159: --resourcePath /data/local/tmp/skia_resoures what about other resources needed by the ...
4 years, 5 months ago (2016-07-11 22:54:53 UTC) #5
liyuqian
Resources option added. https://codereview.chromium.org/2140663002/diff/20001/site/user/quick/android.md File site/user/quick/android.md (left): https://codereview.chromium.org/2140663002/diff/20001/site/user/quick/android.md#oldcode159 site/user/quick/android.md:159: --resourcePath /data/local/tmp/skia_resoures On 2016/07/11 22:54:53, djsollen ...
4 years, 5 months ago (2016-07-12 13:51:56 UTC) #6
djsollen
lgtm
4 years, 5 months ago (2016-07-12 13:53:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2140663002/40001
4 years, 5 months ago (2016-07-12 14:06:31 UTC) #9
jvanverth1
https://codereview.chromium.org/2140663002/diff/40001/site/user/quick/android.md File site/user/quick/android.md (right): https://codereview.chromium.org/2140663002/diff/40001/site/user/quick/android.md#newcode154 site/user/quick/android.md:154: ./platform_tools/android/bin/android_launch_app --resources /data/local/tmp/skia I don't know if this matters, ...
4 years, 5 months ago (2016-07-12 14:23:47 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://skia.googlesource.com/skia/+/e7d15fe870e8d6b0d4b072fc02a2a1c079743485
4 years, 5 months ago (2016-07-12 16:12:42 UTC) #12
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-12 16:12:44 UTC) #13
liyuqian
4 years, 5 months ago (2016-07-12 17:44:58 UTC) #14
Message was sent while issue was closed.
https://codereview.chromium.org/2140663002/diff/40001/site/user/quick/android.md
File site/user/quick/android.md (right):

https://codereview.chromium.org/2140663002/diff/40001/site/user/quick/android...
site/user/quick/android.md:154: ./platform_tools/android/bin/android_launch_app
--resources /data/local/tmp/skia
On 2016/07/12 14:23:47, jvanverth1 wrote:
> I don't know if this matters, but the option in Viewer is --resourcePath.

Thanks, you're right. I'm sending another CL
(https://codereview.chromium.org/2143093002/) to fix this.

Powered by Google App Engine
This is Rietveld 408576698