Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(510)

Issue 2140653002: Fix display at start of offline dinosaur game [iOS] (Closed)

Created:
4 years, 5 months ago by gambard
Modified:
4 years, 5 months ago
CC:
chromium-reviews, kkhorimoto
Base URL:
https://chromium.googlesource.com/chromium/src.git@rex
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix display at start of offline dinosaur game [iOS] This CL fixes the rendering of the dinosaur and the ground at the beginning of the offline dinosaur game. Previously, the dinosaur and the ground were not displayed before the game start on iOS because the sprite was not loaded yet. This CL adds a listener for the loading of the sprite if it is not loaded at the game initialization, allowing it to be loaded before drawing. BUG=627058

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M components/neterror/resources/offline.js View 1 chunk +10 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 6 (3 generated)
gambard
PTAL.
4 years, 5 months ago (2016-07-11 15:13:49 UTC) #2
kkhorimoto
FYI: I'm working on the dinosaur game on iOS and have a fix here that ...
4 years, 5 months ago (2016-07-13 17:57:03 UTC) #5
gambard
4 years, 5 months ago (2016-07-18 06:57:16 UTC) #6
On 2016/07/13 17:57:03, kkhorimoto_ wrote:
> FYI: I'm working on the dinosaur game on iOS and have a fix here that includes
> your changes (plus additional ones necessary to run the game on iOS):
> 
> https://codereview.chromium.org/2144933002/
> 
> I don't know whether you want to just land this so I can rebase my change on
top
> of yours, or just close this CL and let mine land with all the changes needed.

Sure, go ahead and land yours.

Powered by Google App Engine
This is Rietveld 408576698