tools/perf/PRESUBMIT.py - Issue 2140633002: Replace deprecated CQ_EXTRA_TRYBOTS with CQ_INCLUDE_TRYBOTS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/PRESUBMIT.py

Issue 2140633002: Replace deprecated CQ_EXTRA_TRYBOTS with CQ_INCLUDE_TRYBOTS. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove stray change made by editor Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/perf/PRESUBMIT.py

diff --git a/tools/perf/PRESUBMIT.py b/tools/perf/PRESUBMIT.py

index 765801e33140a619aea8d2da9c5c32968f71cf14..05722180034f8637fce2058943e3c3c1ff4ac8ab 100644

--- a/tools/perf/PRESUBMIT.py

+++ b/tools/perf/PRESUBMIT.py

@@ -121,7 +121,7 @@ def PostUploadHook(cl, change, output_api):

issue = cl.issue

original_description = rietveld_obj.get_description(issue)

if not benchmarks_modified or re.search(

- r'^CQ_EXTRA_TRYBOTS=.*', original_description, re.M | re.I):

+ r'^CQ_INCLUDE_TRYBOTS=.*', original_description, re.M | re.I):

return []

results = []

@@ -134,7 +134,7 @@ def PostUploadHook(cl, change, output_api):

bots = ['tryserver.chromium.perf:%s' % s for s in bots]

bots_string = ';'.join(bots)

description = original_description

- description += '\nCQ_EXTRA_TRYBOTS=%s' % bots_string

+ description += '\nCQ_INCLUDE_TRYBOTS=%s' % bots_string

results.append(output_api.PresubmitNotifyResult(

'Automatically added Perf trybots to run Telemetry benchmarks on CQ.'))

« no previous file with comments | « no previous file | no next file » | no next file with comments »