Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(501)

Issue 2140623002: Data structures for Safe Browsing subresource filtering rules. (Closed)

Created:
4 years, 5 months ago by pkalinnikov
Modified:
4 years, 5 months ago
Reviewers:
engedy
CC:
battre
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Data structures for Safe Browsing subresource filtering rules. The rules are defined in two formats: 1) Protocol Buffers, which is used as the wire format for transferring the rules, and is intended to remain relatively stable. 2) FlatBuffers, which is used internally as a compact representation of the rules, and which can be memory mapped into renderer processes directly. This CL also fixes GYP files for flatc for iOS. This is a reland of https://codereview.chromium.org/2086213003/#ps160001 now that the linking issue has been fixed by https://codereview.chromium.org/2094273003/. BUG=609747 Committed: https://crrev.com/4da5767eaa2950e258eae1c90d384628936d0085 Cr-Commit-Position: refs/heads/master@{#404654}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+368 lines, -9 lines) Patch
M components/subresource_filter.gypi View 3 chunks +38 lines, -2 lines 0 comments Download
M components/subresource_filter/core/common/BUILD.gn View 2 chunks +7 lines, -1 line 0 comments Download
A + components/subresource_filter/core/common/flat/BUILD.gn View 1 chunk +3 lines, -3 lines 0 comments Download
A components/subresource_filter/core/common/flat/rules.fbs View 1 chunk +117 lines, -0 lines 0 comments Download
A + components/subresource_filter/core/common/proto/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
A components/subresource_filter/core/common/proto/rules.proto View 1 chunk +196 lines, -0 lines 0 comments Download
M third_party/flatbuffers/flatbuffers.gyp View 4 chunks +5 lines, -1 line 0 comments Download
M third_party/flatbuffers/flatc.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
pkalinnikov
PTAL.
4 years, 5 months ago (2016-07-11 13:45:26 UTC) #4
engedy
I have removed the lines with 'Commit-Position' and the like from the description, to avoid ...
4 years, 5 months ago (2016-07-11 14:31:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2140623002/1
4 years, 5 months ago (2016-07-11 14:35:27 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-11 14:39:44 UTC) #10
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-11 14:39:49 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-11 14:41:00 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4da5767eaa2950e258eae1c90d384628936d0085
Cr-Commit-Position: refs/heads/master@{#404654}

Powered by Google App Engine
This is Rietveld 408576698