|
|
Created:
4 years, 5 months ago by msramek Modified:
4 years, 5 months ago Reviewers:
dschuyler CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionExplicitly specify the vertical scrollbar in the MD settings CDB dialog
Otherwise, a misplaced scrollbar appears (presumably on some related element
from inside cr-dialog's shadow DOM).
On the way, also relax the condition for the "< 714px height" screens to
any media devices - there is no reason not to apply the same in print etc.
BUG=625585
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Committed: https://crrev.com/564cf64fb5e60187511b316edf7b82e71b209e74
Cr-Commit-Position: refs/heads/master@{#406936}
Patch Set 1 #
Messages
Total messages: 17 (8 generated)
Description was changed from ========== Explicitly specify the vertical scrollbar in the MD settings CDB dialog Otherwise, a misplaced scrollbar appears (presumably on some related element from inside cr-dialog's shadow DOM). On the way, also relax the condition for the "< 714px height" screens to any media devices - there is no reason not to apply the same in print etc. BUG=625585 ========== to ========== Explicitly specify the vertical scrollbar in the MD settings CDB dialog Otherwise, a misplaced scrollbar appears (presumably on some related element from inside cr-dialog's shadow DOM). On the way, also relax the condition for the "< 714px height" screens to any media devices - there is no reason not to apply the same in print etc. BUG=625585 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ==========
msramek@chromium.org changed reviewers: + dschuyler@chromium.org
Hi Dave, can you please take a quick look? Thanks, Martin
lgtm
Thanks! (and welcome back :) )
The CQ bit was checked by msramek@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Your CL relies on deprecated CQ feature(s): * Specifying master names in CQ_INCLUDE_TRYBOTS part of description without "master." prefix is deprecated: tryserver.chromium.linux For more details, see http://crbug.com/617627.
Description was changed from ========== Explicitly specify the vertical scrollbar in the MD settings CDB dialog Otherwise, a misplaced scrollbar appears (presumably on some related element from inside cr-dialog's shadow DOM). On the way, also relax the condition for the "< 714px height" screens to any media devices - there is no reason not to apply the same in print etc. BUG=625585 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ========== to ========== Explicitly specify the vertical scrollbar in the MD settings CDB dialog Otherwise, a misplaced scrollbar appears (presumably on some related element from inside cr-dialog's shadow DOM). On the way, also relax the condition for the "< 714px height" screens to any media devices - there is no reason not to apply the same in print etc. BUG=625585 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
The CQ bit was checked by msramek@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Explicitly specify the vertical scrollbar in the MD settings CDB dialog Otherwise, a misplaced scrollbar appears (presumably on some related element from inside cr-dialog's shadow DOM). On the way, also relax the condition for the "< 714px height" screens to any media devices - there is no reason not to apply the same in print etc. BUG=625585 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Explicitly specify the vertical scrollbar in the MD settings CDB dialog Otherwise, a misplaced scrollbar appears (presumably on some related element from inside cr-dialog's shadow DOM). On the way, also relax the condition for the "< 714px height" screens to any media devices - there is no reason not to apply the same in print etc. BUG=625585 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Explicitly specify the vertical scrollbar in the MD settings CDB dialog Otherwise, a misplaced scrollbar appears (presumably on some related element from inside cr-dialog's shadow DOM). On the way, also relax the condition for the "< 714px height" screens to any media devices - there is no reason not to apply the same in print etc. BUG=625585 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Explicitly specify the vertical scrollbar in the MD settings CDB dialog Otherwise, a misplaced scrollbar appears (presumably on some related element from inside cr-dialog's shadow DOM). On the way, also relax the condition for the "< 714px height" screens to any media devices - there is no reason not to apply the same in print etc. BUG=625585 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/564cf64fb5e60187511b316edf7b82e71b209e74 Cr-Commit-Position: refs/heads/master@{#406936} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/564cf64fb5e60187511b316edf7b82e71b209e74 Cr-Commit-Position: refs/heads/master@{#406936} |