Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 2140613002: Explicitly specify the vertical scrollbar in the MD settings CDB dialog (Closed)

Created:
4 years, 5 months ago by msramek
Modified:
4 years, 5 months ago
Reviewers:
dschuyler
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Explicitly specify the vertical scrollbar in the MD settings CDB dialog Otherwise, a misplaced scrollbar appears (presumably on some related element from inside cr-dialog's shadow DOM). On the way, also relax the condition for the "< 714px height" screens to any media devices - there is no reason not to apply the same in print etc. BUG=625585 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/564cf64fb5e60187511b316edf7b82e71b209e74 Cr-Commit-Position: refs/heads/master@{#406936}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.html View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 17 (8 generated)
msramek
Hi Dave, can you please take a quick look? Thanks, Martin
4 years, 5 months ago (2016-07-11 13:34:26 UTC) #3
dschuyler
lgtm
4 years, 5 months ago (2016-07-21 19:25:12 UTC) #4
msramek
Thanks! (and welcome back :) )
4 years, 5 months ago (2016-07-21 19:32:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2140613002/1
4 years, 5 months ago (2016-07-21 19:33:08 UTC) #7
commit-bot: I haz the power
Your CL relies on deprecated CQ feature(s): * Specifying master names in CQ_INCLUDE_TRYBOTS part of ...
4 years, 5 months ago (2016-07-21 19:33:09 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_compile_dbg/builds/100055)
4 years, 5 months ago (2016-07-21 19:43:51 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2140613002/1
4 years, 5 months ago (2016-07-21 20:20:51 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-21 21:10:29 UTC) #15
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 21:12:49 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/564cf64fb5e60187511b316edf7b82e71b209e74
Cr-Commit-Position: refs/heads/master@{#406936}

Powered by Google App Engine
This is Rietveld 408576698